Merged
Conversation
Introduce robust error handling for version determination logic using `from_command`. Add `VersionConfig` parsing to support version configuration from `valhalla.yml`. Replace generic version functions with distinct logic for branch-based and command-based versions.
Added `version.from_command` property in `valhalla.yml` to fetch the version dynamically during release. Updated `README.md` with improved documentation links and refined the configuration instructions to enhance user guidance.
Enhanced error handling and replaced hardcoded dictionary access with a `get_from_dict` utility. Standardized naming for `VersionConfig` to `version_config` for consistency. Updated tests to align with new logic and added new test cases for version-related configurations.
Introduced new test cases: 1. `get_from_dict_test.py` to validate dictionary access with required and optional keys. 2. `release_assets_links_parsing_test.py` to ensure correct parsing of release asset links. 3. `from_config_test.py` to test version retrieval logic including dynamic command execution. Enhanced `.junie/guidelines.md` to include a template for new test case creation.
- Added Renovate configuration and workflow for dependency updates. - Modified `requirements.txt` to include `pytest` and `pytest-cov`. - Updated Python workflow to use `pytest` with coverage reporting. - Integrated Codecov for test coverage analysis.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.