Open
Conversation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref
commented
Feb 8, 2026
Comment on lines
26
to
+27
| # now, we check if there is a rule with value set to at least 2, but it can be 2 rules with different approval users | ||
| # that requires for one approve, what also gives 2 | ||
| # that requires for one approve, which also gives 2 |
Author
There was a problem hiding this comment.
This whole sentence is fairly awkward. My tooling doesn't like it for reasons I'm not addressing here, but this was the simplest change that I could make that made it slightly better.
one approve should probably be one approver or one approval or something. But thinking about it was too much for me...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. While this might look like an automated PR, it isn't. I use tooling I maintain to identify misspellings (and other errors) and then I have a set of simple scripts that I use to make corrections based on the errors. I think through and review each change.
I benefit from iterating on my tooling as I go -- for this PR, I finished a feature that I'd been planning to implement and ran into a rough edge for which I added a small improvement.