Skip to content

Conversation

@hidalgopl
Copy link
Contributor

@hidalgopl hidalgopl commented Dec 9, 2025

Content Description

Preview Link

Internal Reference

Closes ENG-10455

@netlify /docs

Note

Adds documentation for safely upgrading etcd from v3.5 to v3.6 in vCluster deployments.

  • New documentation
    • New guide page at learn-how-to/control-plane/container/safely-upgrade-etcd.mdx (added to main, v0.26.0, v0.27.0, and v0.28.0)
    • Shared fragment _fragments/safely-upgrade-etcd.mdx with version matrix and upgrade paths
  • Updated references
    • Added cross-reference links in existing embedded.mdx files across versioned docs
    • Minor whitespace cleanup in InterpolatedCodeBlock tags
  • Content includes
    • Version matrix mapping vCluster versions to etcd versions (updated to v3.5.25 and added v0.26.5)
    • Separate upgrade paths for embedded vs deployed etcd
    • YAML configuration example for setting etcd image tag

Generated by Claude for commit 30db38a. Updates automatically on new commits.

Signed-off-by: Paweł Bojanowski <[email protected]>
@hidalgopl hidalgopl requested a review from a team as a code owner December 9, 2025 11:56
@netlify
Copy link

netlify bot commented Dec 9, 2025

Deploy Preview for vcluster-docs-site ready!

Name Link
🔨 Latest commit fa20b77
🔍 Latest deploy log https://app.netlify.com/projects/vcluster-docs-site/deploys/69453f505bef2a000806a896
😎 Deploy Preview https://deploy-preview-1476--vcluster-docs-site.netlify.app/docs
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hidalgopl hidalgopl marked this pull request as draft December 9, 2025 11:56
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Signed-off-by: Paweł Bojanowski <[email protected]>
Signed-off-by: Paweł Bojanowski <[email protected]>
Signed-off-by: Paweł Bojanowski <[email protected]>
@hidalgopl hidalgopl force-pushed the add-how-to-upgrade-etcd-to-v3.6 branch from bfee52d to eaae54e Compare December 10, 2025 11:18
Signed-off-by: Paweł Bojanowski <[email protected]>
cbron
cbron previously approved these changes Dec 10, 2025
@hidalgopl hidalgopl marked this pull request as ready for review December 11, 2025 14:50
@github-actions
Copy link
Contributor

Review complete for a613918 - no issues found.

Summary:

  • Documentation structure is correct with shared fragment and version-specific pages
  • Internal links are valid (backup paths differ between v0.26 and later versions, both correctly handled)
  • YAML configuration example is valid
  • Whitespace changes in embedded.mdx files are consistent cleanup

Note: The docs use "ETCD" capitalization which differs from the lowercase "etcd" recommended in CONTRIBUTING.md. This appears to be a stylistic choice for emphasis in headings/labels and is consistent within this PR.

E2E Tests: Skipped - this PR adds text content and YAML examples without mermaid diagrams or structural changes requiring visual testing.

Signed-off-by: Paweł Bojanowski <[email protected]>
@loft-bot
Copy link
Contributor

Review complete for 30db38a - no issues found.

Changes since last review (a613918):

  • Updated etcd version references from v3.5.24 to v3.5.25 in the version matrix and upgrade instructions
  • Added v0.26.5 to the version matrix with etcd v3.5.25

Validation:

  • Internal links verified (backup documentation paths are correct for each version)
  • YAML configuration example validated against vCluster schema
  • Documentation structure follows existing patterns

E2E Tests: Skipped - this PR contains text content updates only (version number changes). No mermaid diagrams or structural changes requiring visual testing.

Signed-off-by: Paweł Bojanowski <[email protected]>
Signed-off-by: Paweł Bojanowski <[email protected]>
Signed-off-by: Paweł Bojanowski <[email protected]>
Signed-off-by: Paweł Bojanowski <[email protected]>
Signed-off-by: Paweł Bojanowski <[email protected]>
Signed-off-by: Paweł Bojanowski <[email protected]>
@Piotr1215 Piotr1215 force-pushed the add-how-to-upgrade-etcd-to-v3.6 branch from 30db38a to a9f5fbf Compare December 19, 2025 10:34
@loft-bot
Copy link
Contributor

loft-bot commented Dec 19, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

@github-actions
Copy link
Contributor

Claude Code review failed to complete. This may be due to API rate limits or network issues. The PR can still be reviewed manually.

@loft-bot
Copy link
Contributor

loft-bot commented Dec 19, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

@github-actions
Copy link
Contributor

Claude Code review failed to complete. This may be due to API rate limits or network issues. The PR can still be reviewed manually.

@Piotr1215 Piotr1215 merged commit d26ea57 into main Dec 19, 2025
30 of 33 checks passed
@Piotr1215 Piotr1215 deleted the add-how-to-upgrade-etcd-to-v3.6 branch December 19, 2025 13:15
Piotr1215 pushed a commit that referenced this pull request Dec 19, 2025
* Backport: Copy vcluster/_fragments/safely-upgrade-etcd.mdx to vcluster_versioned_docs/version-0.28.0/_fragments/safely-upgrade-etcd.mdx

* Backport: Copy vcluster/configure/vcluster-yaml/control-plane/components/backing-store/etcd/embedded.mdx to vcluster_versioned_docs/version-0.28.0/configure/vcluster-yaml/control-plane/components/backing-store/etcd/embedded.mdx

* Backport: Copy vcluster/learn-how-to/control-plane/container/safely-upgrade-etcd.mdx to vcluster_versioned_docs/version-0.28.0/learn-how-to/control-plane/container/safely-upgrade-etcd.mdx

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Piotr1215 pushed a commit that referenced this pull request Dec 19, 2025
* Backport: Copy vcluster/_fragments/safely-upgrade-etcd.mdx to vcluster_versioned_docs/version-0.29.0/_fragments/safely-upgrade-etcd.mdx

* Backport: Copy vcluster/configure/vcluster-yaml/control-plane/components/backing-store/etcd/embedded.mdx to vcluster_versioned_docs/version-0.29.0/configure/vcluster-yaml/control-plane/components/backing-store/etcd/embedded.mdx

* Backport: Copy vcluster/learn-how-to/control-plane/container/safely-upgrade-etcd.mdx to vcluster_versioned_docs/version-0.29.0/learn-how-to/control-plane/container/safely-upgrade-etcd.mdx

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Piotr1215 pushed a commit that referenced this pull request Dec 19, 2025
* Backport: Copy vcluster/_fragments/safely-upgrade-etcd.mdx to vcluster_versioned_docs/version-0.30.0/_fragments/safely-upgrade-etcd.mdx

* Backport: Copy vcluster/configure/vcluster-yaml/control-plane/components/backing-store/etcd/embedded.mdx to vcluster_versioned_docs/version-0.30.0/configure/vcluster-yaml/control-plane/components/backing-store/etcd/embedded.mdx

* Backport: Copy vcluster/learn-how-to/control-plane/container/safely-upgrade-etcd.mdx to vcluster_versioned_docs/version-0.30.0/learn-how-to/control-plane/container/safely-upgrade-etcd.mdx

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants