Skip to content

Make silo replicas configurable and add PDBs for HA #5774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
google-labs-jules wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Make silo replicas configurable and add PDBs for HA #5774

google-labs-jules wants to merge 2 commits into from
+504 −1

Conversation

@google-labs-jules
Copy link
Contributor

@google-labs-jules google-labs-jules bot commented Dec 26, 2025 •
edited by loculus-bot
Loading

This PR addresses the issue of downtime during Kubernetes node drains for services like silo and lapis.

Changes:

  1. Configurable Replicas:
    • Added replicas.silo to values.yaml and values.schema.json.
    • Updated silo-deployment.yaml to use this value instead of being hardcoded to 1.
  2. PodDisruptionBudgets (PDB):
    • Added a new pdb section to values.yaml for website, backend, silo, and lapis.
    • Created new PDB templates for these services.
    • Default setting is maxUnavailable: 1, which allows node drains even with 1 replica (causing downtime) but ensures availability if replicas are scaled to >1.
  3. Pod Anti-Affinity:
    • Added preferredDuringSchedulingIgnoredDuringExecution anti-affinity rules to loculus-backend, loculus-website, lapis-deployment, and silo-deployment templates.
    • This encourages Kubernetes to schedule replicas on different nodes to maximize availability, without strictly enforcing it (which could block scheduling in small clusters).

PR created automatically by Jules for task 8320007074027152157 started by @corneliusroemer

🚀 Preview: Add preview label to enable

@google-labs-jules
feat(kubernetes): make silo replicas configurable and add PDBs
8767f69 
- Makes `silo` replica count configurable in `values.yaml` (default: 1).
- Adds `PodDisruptionBudget` templates for `website`, `backend`, `silo`, and `lapis` with configurable `maxUnavailable` (default: 1).
- Adds `podAntiAffinity` (preferred) to deployment templates for `website`, `backend`, `silo`, and `lapis` to encourage scheduling on different nodes.
- Updates `values.schema.json` to include new configuration options.
@google-labs-jules
Copy link
Contributor Author

google-labs-jules bot commented Dec 26, 2025

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@google-labs-jules
feat(kubernetes): make silo replicas configurable and add PDBs
cff7537 
- Makes `silo` replica count configurable in `values.yaml` (default: 1).
- Adds `PodDisruptionBudget` templates for `website`, `backend`, `silo`, and `lapis` (in deployment files) with configurable `maxUnavailable` (default: 1).
- Adds `podAntiAffinity` (preferred) to deployment templates for `website`, `backend`, `silo`, and `lapis` to encourage scheduling on different nodes.
- Updates `values.schema.json` to include new configuration options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant