Skip to content

Conversation

@corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented Dec 4, 2025

resolves #5627

🚀 Preview: Add preview label to enable

@corneliusroemer corneliusroemer changed the base branch from main to edit-page-anya December 4, 2025 17:05
Copy link
Contributor

@anna-parker anna-parker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add some of the integration test changes I made in https://github.com/loculus-project/loculus/pull/5629/files?

Update: I cherrypicked your changes into #5629, added tests and made the difference between header and ID clearer on the edit page

@corneliusroemer
Copy link
Contributor Author

could you add some of the integration test changes I made in https://github.com/loculus-project/loculus/pull/5629/files?

They don't matter? This fix here is contained and should be good to go?

@anna-parker
Copy link
Contributor

In https://github.com/loculus-project/loculus/pull/5629/files I also improve the error message - we were checking if the full fasta header was the same not the fasta ID. If we only merge these changes here a user could submit a sequence with the same fastaID and a different description - causing submission issues when this is sent to the backend

@corneliusroemer
Copy link
Contributor Author

superseded by #5629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants