-
Notifications
You must be signed in to change notification settings - Fork 9
feat!(backend): refactor multi-segment submission #5261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ebfc127 to
417d711
Compare
backend/src/main/kotlin/org/loculus/backend/service/submission/UploadDatabaseService.kt
Outdated
Show resolved
Hide resolved
7e5f673 to
d4700af
Compare
eb49c79 to
8aaec9d
Compare
d4700af to
09dae7f
Compare
8aaec9d to
0129a69
Compare
09dae7f to
7395166
Compare
|
As discussed we should change to a space-separated internal separator. We could also allow a different column for each segment (and only require that the prefix be called fastaId) -> lets maybe ask on microbioinfo which option would be easier for people Update: consensus for this option reached: https://microbial-bioinfo.slack.com/archives/CB0HYT53M/p1760961465729399 |
45bdaa6 to
520c6cd
Compare
4148024 to
a0a6f64
Compare
a0a6f64 to
33c5bac
Compare
cb15fe7 to
275eb65
Compare
a957c8b to
e74f175
Compare
…ward compatibility
28bd185 to
ce63d51
Compare
53595fa to
8a305fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
backend/src/main/kotlin/org/loculus/backend/service/submission/UploadDatabaseService.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/model/SubmitModel.kt
Outdated
Show resolved
Hide resolved
b3fe577 to
e7dfcfd
Compare
f27aa67 to
fc9ec01
Compare
|
I will close this in favor of #5398 |
resolves #4708, #4734
partially resolves #5392, #5185 (comment)
Breaking Changes
When users submit to multi-segmented organisms and want to group multiple segments under one metadata entry they are required to add an additional
fastaIdcolumn with a comma-separated list of thefastaIds(fasta header IDs) of the respective sequences. If nofastaIdcolumn is supplied thesubmissionIdwill be used instead and the backend will assume that (as in the single-segmented case) there is a one-to-one mapping of metadatasubmissionIdtofastaId.This requires:
Future Steps
For simplicity in this PR prepro does not yet use a minimizer index to assign segments but parses the fasta header (as the backend did before). In future steps we should
PR Checklist
🚀 Preview: https://multi-segment-submission.loculus.org