Refactor Player from generic class to inheritance hierarchy#285
Merged
Conversation
Replace Player<IsFull> conditional type pattern with Player + Player.Profiled class hierarchy using namespace merge. Player is the lightweight identity (id + name), Player.Profiled extends it with full profile data. Add Players domain class as a manager with resolve/fetch/cache, replacing the PlayerCache. Remove accountCreationDate from createRaffleWin since it was always null (Raffle only has player identity, not profile data).
- Make Player.client truly private (#client) - Rename parseWhois to parseNameFromWhois for clarity - Simplify Players.resolve() to a single expression - Add Players domain tests (resolve, fetch, caching, getNameFromId)
identifyPlayer now returns Player instead of Player.Profiled, saving a showplayer.php request for done, brainiac, and skills commands. whois calls .fetch() itself since it needs the full profile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Player<IsFull extends boolean>generic with aPlayer+Player.Profiledclass hierarchy (inspired by Discord.js patterns)Playersmanager domain (kolClient.players.resolve()/.fetch()/.getNameFromId()) that owns caching and lookup logicCache.ts(absorbed intoPlayers)Design
What's better vs the generic approach:
as unknown as Player<true>casts, noIf<>helperinstanceofnarrowing — standard TypeScript, no custom type guardsfetch()— calling onPlayer.ProfiledreturnsPlayer.Profiled(not null)winner.player.createdDatein Raffle was always null (removed from thecreateRaffleWincall)