Skip to content

Conversation

@farzonl
Copy link
Member

@farzonl farzonl commented Nov 26, 2025

fixes #506

This PR is a partner pr to llvm/llvm-project#168915 It should not merge until after the llvm pr merges. That way I won't have XFAIL the clang code.

It adds 3 types of tests elementwise casts, vector elementwise casts,
and trunc casts.

It also moves the existing matrix tests into a Matrix folder for better organization.

Copy link

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farzonl farzonl force-pushed the matrix_trunc_elementwise_cast/issues-506 branch from 3a7a351 to a2cc7ed Compare December 3, 2025 00:10
fixes llvm#506

This PR is a partner pr to llvm/llvm-project#168915
It should not run until after the llvm pr merges. That way I won't have
XFAIL the clang code.

It adds 3 types of tests elementwise casts, vector elementwise casts,
   and trunc casts.

It also moves the existing matrix tests into a Matrix folder for better
organization.
@farzonl farzonl force-pushed the matrix_trunc_elementwise_cast/issues-506 branch from 181b019 to b74ad4f Compare December 3, 2025 19:20
@farzonl
Copy link
Member Author

farzonl commented Dec 4, 2025

Remaining failures are unrelated to this pr.

@farzonl farzonl merged commit 1901531 into llvm:main Dec 4, 2025
10 of 12 checks passed
@github-project-automation github-project-automation bot moved this to Closed in HLSL Support Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

Add tests for Matrix cast

3 participants