[ShrinkWrap][NFC] Test with load from constant pool preventing shrink #162476
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| --- | | ||
| ; RUN: llc -x=mir -simplify-mir -run-pass=shrink-wrap -o - %s | FileCheck %s | ||
| ; CHECK-NOT: savePoint | ||
| ; CHECK-NOT: restorePoint | ||
|
There was a problem hiding this comment. Could you add a comment on what this is testing and what we are checking here? |
||
|
|
||
| declare double @foo() | ||
|
|
||
| define double @shrink_wrap_load_from_const_pool(double %q) { | ||
| entry: | ||
| %0 = fcmp oeq double %q, 3.125500e+02 | ||
| br i1 %0, label %common.ret, label %if.else | ||
|
|
||
| common.ret: ; preds = %if.else, %entry, %exit1 | ||
| %common.ret.op = phi double [ %3, %exit1 ], [ 0.000000e+00, %entry ], [ 0.000000e+00, %if.else ] | ||
| ret double %common.ret.op | ||
|
|
||
| if.else: ; preds = %entry | ||
| %1 = call double @foo() | ||
| %2 = fcmp oeq double %1, 0.000000e+00 | ||
| br i1 %2, label %exit1, label %common.ret | ||
|
|
||
| exit1: ; preds = %if.else | ||
| %3 = call double @foo() | ||
| br label %common.ret | ||
| } | ||
| ... | ||
| # Following code has a load from constant pool. Accessing constant pool must not | ||
| # be considered as a stack access and hence, shrink wrapping must happen. | ||
| --- | ||
| name: shrink_wrap_load_from_const_pool | ||
| tracksRegLiveness: true | ||
| constants: | ||
| - id: 0 | ||
| value: 'double 3.125500e+02' | ||
| alignment: 8 | ||
| body: | | ||
| bb.0.entry: | ||
|
There was a problem hiding this comment. Get rid of the There was a problem hiding this comment. keeping the IR names for the reason mentioned above. |
||
| successors: %bb.4(0x50000000), %bb.2(0x30000000) | ||
| liveins: $d0 | ||
|
|
||
| renamable $d1 = COPY $d0 | ||
| renamable $x8 = ADRP target-flags(aarch64-page) %const.0 | ||
| renamable $d2 = LDRDui killed renamable $x8, target-flags(aarch64-pageoff, aarch64-nc) %const.0 :: (load (s64) from constant-pool) | ||
| renamable $d0 = FMOVD0 | ||
| nofpexcept FCMPDrr killed renamable $d1, killed renamable $d2, implicit-def $nzcv, implicit $fpcr | ||
| Bcc 1, %bb.2, implicit killed $nzcv | ||
|
|
||
| bb.4: | ||
| liveins: $d0 | ||
|
|
||
| bb.1.common.ret: | ||
| liveins: $d0 | ||
|
|
||
| RET_ReallyLR implicit $d0 | ||
|
|
||
| bb.2.if.else: | ||
| successors: %bb.3(0x50000000), %bb.1(0x30000000) | ||
|
|
||
| ADJCALLSTACKDOWN 0, 0, implicit-def dead $sp, implicit $sp | ||
| BL @foo, csr_aarch64_aapcs, implicit-def dead $lr, implicit $sp, implicit-def $sp, implicit-def $d0 | ||
| ADJCALLSTACKUP 0, 0, implicit-def dead $sp, implicit $sp | ||
| renamable $d1 = COPY $d0 | ||
| renamable $d0 = FMOVD0 | ||
| nofpexcept FCMPDri killed renamable $d1, implicit-def $nzcv, implicit $fpcr | ||
| Bcc 1, %bb.1, implicit killed $nzcv | ||
| B %bb.3 | ||
|
|
||
| bb.3.exit1: | ||
| ADJCALLSTACKDOWN 0, 0, implicit-def dead $sp, implicit $sp | ||
| BL @foo, csr_aarch64_aapcs, implicit-def dead $lr, implicit $sp, implicit-def $sp, implicit-def $d0 | ||
| ADJCALLSTACKUP 0, 0, implicit-def dead $sp, implicit $sp | ||
| B %bb.1 | ||
| ... | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need the LLVM section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel it can just be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IR section is not needed. But, for someone like me who is not that great with codegen, I feel LLVM IR gives good sense of how the mir code was derived in the first place.
If you still insist, will remove it.