Skip to content

Conversation

@skc7
Copy link
Contributor

@skc7 skc7 commented Nov 27, 2025

This PR adds CIRGenBuiltinAMDGPU.cpp file for AMDGPU specific builtin codegen support.
Lists out all the builtins that are currently supported for codegen in clang/lib/CodeGen/TargetBuiltins/AMDGPU.cpp.
All builtins codegen are currently "NYI".

@github-actions
Copy link

github-actions bot commented Nov 27, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

@skc7 skc7 marked this pull request as ready for review November 27, 2025 16:15
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending minor nit

@bcardosolopes bcardosolopes changed the title [CIR][AMDGPU] Add CIRGenBuiltinAMDGPU file to support AMDGPU builtins codegen [CIR][AMDGPU][NFC] Add CIRGenBuiltinAMDGPU file to support AMDGPU builtins codegen Dec 2, 2025
@skc7
Copy link
Contributor Author

skc7 commented Dec 2, 2025

LGTM pending minor nit

@bcardosolopes I don't have access to merge. Shall I wait for approvals from other reviewers?

@bcardosolopes bcardosolopes merged commit 2aced5d into llvm:main Dec 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants