Skip to content

Changes for kripke and its dependencies#1368

Draft
rfhaque wants to merge 3 commits into
developfrom
kripke_upstream_spack
Draft

Changes for kripke and its dependencies#1368
rfhaque wants to merge 3 commits into
developfrom
kripke_upstream_spack

Conversation

@rfhaque

@rfhaque rfhaque commented May 31, 2026

Copy link
Copy Markdown
Collaborator

This PR:

  • Adds throughput scaling parameters to the kripke experiment.py
  • Updates kripke spack package to use the latest develop version of RAJA, Umpire, CHAI and camp.
  • Adds the cxxstd variant to CHAI

Adding/modifying a benchmark (docs: Adding a Benchmark)

  • Depends on Allocate and initialize memory on the GPU Kripke#76
  • If package.py upstreamed to Spack is insufficient, add/modify repo/benchmark_name/package.py plus: create, self-assign, and link here a follow up issue with a link to the PR in the Spack repo.
  • Add/modify an experiments/benchmark_name/experiment.py to define an experiment

…aration to upstream to the spack-packages repository
@github-actions github-actions Bot added the experiment New or modified experiment label May 31, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.26%. Comparing base (665645b) to head (64206e8).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1368      +/-   ##
===========================================
+ Coverage    62.71%   64.26%   +1.54%     
===========================================
  Files           49       49              
  Lines         3811     3811              
  Branches       338      338              
===========================================
+ Hits          2390     2449      +59     
+ Misses        1402     1343      -59     
  Partials        19       19              
Files with missing lines Coverage Δ
experiments/kripke/experiment.py 24.52% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

experiment New or modified experiment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants