Skip to content

Sparta changes#1299

Open
rfhaque wants to merge 26 commits into
developfrom
sparta_changes
Open

Sparta changes#1299
rfhaque wants to merge 26 commits into
developfrom
sparta_changes

Conversation

@rfhaque

@rfhaque rfhaque commented Mar 26, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR

  • Adds input parameters relevant to El Capitan
  • Adds the sparta source commit 478143bc recommended for El Cap
  • Sets the input problem for El Cap
  • Depends on Update Kokkos library in SPARTA to v5.0.2 sparta/sparta#596
  • Adds a kokkos variant to support v4 features in Sparta. This must be removed once the dependence of Sparta on Kokkos 4 is removed.

Adding/modifying a benchmark (docs: Adding a Benchmark)

  • If package.py upstreamed to Spack is insufficient, add/modify repo/benchmark_name/package.py plus: create, self-assign, and link here a follow up issue with a link to the PR in the Spack repo.
  • If application.py upstreamed to Ramble is insufficient, add/modify repo/benchmark_name/application.py plus: create, self-assign, and link here a follow up issue with a link to the PR in the Ramble repo.
  • Add/modify an experiments/benchmark_name/experiment.py to define an experiment

@rfhaque rfhaque requested a review from pearce8 March 26, 2026 19:06
@github-actions github-actions Bot added the experiment New or modified experiment label Mar 26, 2026
@pearce8 pearce8 added this to the April 2026 milestone Mar 30, 2026
@pearce8 pearce8 added the changes requested Changes requested label Mar 30, 2026
@pearce8 pearce8 modified the milestones: April 2026, March 2026 Apr 24, 2026
@pearce8 pearce8 modified the milestones: March 2026, May 2026 May 4, 2026
@pearce8 pearce8 mentioned this pull request May 26, 2026
21 tasks
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.36%. Comparing base (90ac2c9) to head (2894630).
⚠️ Report is 23 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1299      +/-   ##
===========================================
+ Coverage    62.82%   64.36%   +1.54%     
===========================================
  Files           49       49              
  Lines         3822     3822              
  Branches       339      339              
===========================================
+ Hits          2401     2460      +59     
+ Misses        1402     1343      -59     
  Partials        19       19              

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes requested Changes requested experiment New or modified experiment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants