Skip to content

Update to C++20#1033

Merged
kab163 merged 36 commits intodevelopfrom
kab163/update-c++20
Mar 31, 2026
Merged

Update to C++20#1033
kab163 merged 36 commits intodevelopfrom
kab163/update-c++20

Conversation

@kab163
Copy link
Copy Markdown
Collaborator

@kab163 kab163 commented Dec 18, 2025

No description provided.

@kab163
Copy link
Copy Markdown
Collaborator Author

kab163 commented Dec 19, 2025

It seems there are some C++20 compatibility issues in the current version of fmt, so will see how updating to 11.1.0 works

@adayton1
Copy link
Copy Markdown
Member

It seems there are some C++20 compatibility issues in the current version of fmt, so will see how updating to 11.1.0 works

I would suggest updating to 12.1.0.

Comment thread CMakeLists.txt
@kab163
Copy link
Copy Markdown
Collaborator Author

kab163 commented Dec 19, 2025

On matrix, these commands work:
$ ml cmake/3.30.5
$ ml cuda/12.9.1
$ ml clang/19.1.3-magic
$ cmake -DENABLE_CUDA=On -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_COMPILER=clang -DCMAKE_CUDA_ARCHITECTURES=90 -DBLT_CXX_STD=c++20 -DENABLE_OPENMP=On -DCUDA_TOOLKIT_ROOT_DIR=/usr/tce/packages/cuda/cuda-12.9.1 -DCMAKE_CUDA_COMPILER=/usr/tce/packages/cuda/cuda-12.9.1/bin/nvcc ../

So to make C++20 work, we need an updated default cmake version - at least 3.25+
cmake/3.25.2 + cuda/12.2.2 + clang/14.0.6 also works

@kab163 kab163 marked this pull request as ready for review January 28, 2026 16:44
@kab163
Copy link
Copy Markdown
Collaborator Author

kab163 commented Jan 28, 2026

Waiting until after the Feb 3rd RAJA discussion (regarding C++20) for merging....
Will merge when ready!

@rhornung67
Copy link
Copy Markdown
Member

Waiting until after the Feb 3rd RAJA discussion (regarding C++20) for merging....

@kab163 I think our plan is to require C++20 for the next RAJA Suite release (mid-summer) and we currently test with it. So go ahead and merge as you wish.

evaleev added a commit to ValeevGroup/SeQuant that referenced this pull request Feb 9, 2026
evaleev added a commit to ValeevGroup/SeQuant that referenced this pull request Feb 9, 2026
evaleev added a commit to ValeevGroup/tiledarray that referenced this pull request Feb 9, 2026
evaleev added a commit to ValeevGroup/SeQuant that referenced this pull request Feb 9, 2026
evaleev added a commit to ValeevGroup/tiledarray that referenced this pull request Feb 9, 2026
evaleev added a commit to ValeevGroup/SeQuant that referenced this pull request Feb 9, 2026
evaleev added a commit to ValeevGroup/SeQuant that referenced this pull request Feb 9, 2026
evaleev added a commit to ValeevGroup/tiledarray that referenced this pull request Feb 27, 2026
Comment thread CMakeLists.txt Outdated
Comment thread Dockerfile Outdated
kab163 and others added 4 commits March 11, 2026 09:05
Comment thread tests/integration/memory_resource_traits_tests.cpp Outdated
Copy link
Copy Markdown
Member

@davidbeckingsale davidbeckingsale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kab163 kab163 merged commit 5ff0d69 into develop Mar 31, 2026
18 checks passed
@kab163 kab163 deleted the kab163/update-c++20 branch March 31, 2026 20:28
evaleev added a commit to ValeevGroup/umpire-cxx-allocator that referenced this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants