draft: introduce concepts to pattern/forall.hpp#1990
Open
johnbowen42 wants to merge 4 commits intofeature/bowen/cpp20from
Open
draft: introduce concepts to pattern/forall.hpp#1990johnbowen42 wants to merge 4 commits intofeature/bowen/cpp20from
johnbowen42 wants to merge 4 commits intofeature/bowen/cpp20from
Conversation
MrBurmark
reviewed
Feb 19, 2026
| concepts::negate<type_traits::is_indexset_policy<ExecutionPolicy>>, | ||
| type_traits::is_range<Container>> | ||
| forall(Res r, ExecutionPolicy&& p, Container&& c, LoopBody&& loop_body) | ||
| RAJA_INLINE RAJA::resources::EventProxy<Res> forall(Res r, |
Member
There was a problem hiding this comment.
Suggested change
| RAJA_INLINE RAJA::resources::EventProxy<Res> forall(Res r, | |
| requires(!IndexSetPolicy<ExecutionPolicy>) | |
| RAJA_INLINE RAJA::resources::EventProxy<Res> forall(Res r, |
| template<ForallPolicy ExecutionPolicy, | ||
| Resource Res, | ||
| RandomAccessRange Container, | ||
| Integer IndexType, |
Member
There was a problem hiding this comment.
Index type and container appear in other templates above, should they also use Integer and RandomAccessRange?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this draft PR, I am experimenting with the idea of replacing SFINAE within RAJA with concepts and requires statements, where further disambiguation is needed