Add SubView class by gberg617 · Pull Request #1915 · llnl/RAJA

gberg617 · 2025-09-19T21:11:25Z

Summary

This WIP PR adds the SubView class. This class stores a view-type object and a tuple of slices that indicate how to access the view's underlying data. The following slice types are supported:
- range slice: Indexes a subset of the original dimension's extents. Does not reduce dimensionality.
- fixed slice: Indexes along a fixed value of a given dimension. Reduces dimensionality.
- no slice: Indexes according to the original view's layout along the given dimension. Does not reduce dimensionality.

A few simple examples are provided below:

    View<Index_type, Layout<2>> view(&my_data[0][0], Layout<2>(3,3));

    // "sv1 = View[1:3,:]"
    auto sv1 = SubView(view, RangeSlice{1,3}, NoSlice{});

    // "sv2 = View[1:3,1]"
    auto sv2 = SubView(view, RangeSlice{1,3}, FixedSlice{1});

Here, sv1 and sv2 are subviews of dimensions (2,3) and (2) respectively.

gberg617 · 2025-09-19T21:12:32Z

This PR is still a WIP!

include/RAJA/util/SubView.hpp

MrBurmark · 2025-09-19T21:33:41Z

include/RAJA/util/SubView.hpp

+RAJA_INLINE RAJA_HOST_DEVICE constexpr auto array_to_tuple_impl(const camp::array<T, N>& arr, camp::idx_seq<Is...>) {
+    return camp::make_tuple(arr[Is]...);
+}
+
+template <typename T, size_t N>
+RAJA_INLINE RAJA_HOST_DEVICE constexpr auto array_to_tuple(const camp::array<T, N>& arr) {
+    return array_to_tuple_impl(arr, camp::make_idx_seq_t<N>{});
+}


Do we not have this somewhere?

If not it would be good to add it in a more general header.

Agreed. I'll look into moving this to camp.

This function wasn't eventually needed. That said, I can still add something like this to camp if you think it could be useful.

include/RAJA/util/SubView.hpp

gberg617 · 2025-09-30T01:08:49Z

test/unit/view-layout/test-subview.cpp

+
+}
+
+// void test_subviewGPU() {


To Do: Fix GPU tests.

include/RAJA/util/SubView.hpp

test/unit/view-layout/test-subview.cpp

gberg617 · 2025-10-11T02:09:07Z

I'm considering separating the SubView holding the view from the slices that are used to access the view, somewhat analogous to the approach of having layouts and Views be separate classes. Any thoughts on this?

include/RAJA/util/SubView.hpp

include/RAJA/util/for_each.hpp

include/RAJA/util/SubView.hpp

…pen interval [start, end) and added more checks for StridedSlice size

tpl/camp

…assert to SubRegion

gberg617 · 2026-03-04T21:21:06Z

include/RAJA/util/View.hpp

  using NonConstView =
      MultiView<nc_value_type, layout_type, P2Pidx, nc_pointer_type>;

+  static constexpr size_t n_dims = layout_type::n_dims + 1;


@rchen20 Does this look right for MultiViews?

…ith projected dimensions

2. Replaced camp::array usage with std::array. 3. Fixed and simplified get_dim_stride and get_parent_dim_stride. 4. Replaced usage of IndexType with size_t where appropriate.

gberg617 · 2026-03-05T19:05:29Z

include/RAJA/util/SubView.hpp

+    }
+
+    template<size_t DIM>
+    RAJA_INLINE RAJA_HOST_DEVICE constexpr auto get_parent_dim_stride() const {


I'm not sure how useful get_parent_dim_stride() is.

gberg617 marked this pull request as draft September 19, 2025 21:12

gberg617 self-assigned this Sep 19, 2025

MrBurmark reviewed Sep 19, 2025

View reviewed changes

include/RAJA/util/SubView.hpp Outdated Show resolved Hide resolved

MrBurmark reviewed Sep 19, 2025

View reviewed changes

include/RAJA/util/SubView.hpp Outdated Show resolved Hide resolved

MrBurmark reviewed Sep 19, 2025

View reviewed changes

include/RAJA/util/SubView.hpp Outdated Show resolved Hide resolved

gberg617 force-pushed the feature/bergel1/subview branch from 804abcd to 5ba920d Compare September 30, 2025 01:08

gberg617 commented Sep 30, 2025

View reviewed changes

test/unit/view-layout/test-subview.cpp Outdated

}

// void test_subviewGPU() {

Copy link

Contributor Author

gberg617 Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To Do: Fix GPU tests.

gberg617 changed the title ~~Feature/bergel1/subview~~ Add SubView class Sep 30, 2025

gberg617 requested review from adayton1, artv3, rchen20 and rhornung67 September 30, 2025 01:11

MrBurmark reviewed Sep 30, 2025

View reviewed changes

include/RAJA/util/SubView.hpp Outdated Show resolved Hide resolved

MrBurmark reviewed Sep 30, 2025

View reviewed changes

include/RAJA/util/SubView.hpp Outdated Show resolved Hide resolved

MrBurmark reviewed Sep 30, 2025

View reviewed changes

include/RAJA/util/SubView.hpp Outdated Show resolved Hide resolved

MrBurmark reviewed Sep 30, 2025

View reviewed changes

include/RAJA/util/SubView.hpp Outdated Show resolved Hide resolved

MrBurmark reviewed Sep 30, 2025

View reviewed changes

include/RAJA/util/SubView.hpp Outdated Show resolved Hide resolved

MrBurmark reviewed Sep 30, 2025

View reviewed changes

include/RAJA/util/SubView.hpp Outdated Show resolved Hide resolved

MrBurmark reviewed Oct 2, 2025

View reviewed changes

include/RAJA/util/SubView.hpp Outdated Show resolved Hide resolved

rcarson3 reviewed Oct 2, 2025

View reviewed changes

test/unit/view-layout/test-subview.cpp Show resolved Hide resolved

MrBurmark reviewed Oct 11, 2025

View reviewed changes

include/RAJA/util/SubView.hpp Outdated Show resolved Hide resolved

MrBurmark reviewed Oct 11, 2025

View reviewed changes

include/RAJA/util/SubView.hpp Outdated Show resolved Hide resolved

MrBurmark reviewed Oct 11, 2025

View reviewed changes

include/RAJA/util/SubView.hpp Outdated Show resolved Hide resolved

MrBurmark reviewed Oct 11, 2025

View reviewed changes

include/RAJA/util/SubView.hpp Outdated Show resolved Hide resolved

MrBurmark reviewed Oct 11, 2025

View reviewed changes

include/RAJA/util/SubView.hpp Outdated Show resolved Hide resolved

MrBurmark reviewed Oct 11, 2025

View reviewed changes

include/RAJA/util/for_each.hpp Outdated Show resolved Hide resolved

MrBurmark reviewed Oct 11, 2025

View reviewed changes

include/RAJA/util/for_each.hpp Outdated Show resolved Hide resolved

gberg617 added 13 commits February 27, 2026 13:20

Added tests

075ea15

small fixes

12c1502

updates to test

ef789df

various changes/fixes to address comments

8399981

implemented for_each_index

23586fa

various more simplifications

d216c17

added set/get slice methods and test

029736e

made simplifications to map and parent_indices

61f8b0b

started adding various size/dim methods

c151057

started implementing SubLayout

f16d980

first attempt at changing to SubLayout

2df7362

made some changes to testing subview/sublayouts

747f5c7

Made various fixes to address comments.

efa96d5

gberg617 force-pushed the feature/bergel1/subview branch from 1e928d3 to efa96d5 Compare February 28, 2026 01:09

added negative stride support for StridedSlice

7b9d048

gberg617 commented Mar 3, 2026

View reviewed changes

include/RAJA/util/SubView.hpp Outdated Show resolved Hide resolved

modified RangeSlice and StridedSlice sizes to only include the half-o…

0ec874c

…pen interval [start, end) and added more checks for StridedSlice size

artv3 reviewed Mar 4, 2026

View reviewed changes

tpl/camp Show resolved Hide resolved

gberg617 added 2 commits March 4, 2026 12:36

minor fixes to address comments

54e3e8b

added n_dims to all view types and added n_dims == num_slices static_…

0b198af

…assert to SubRegion

gberg617 commented Mar 4, 2026

View reviewed changes

gberg617 added 3 commits March 4, 2026 17:26

modifications to size(), size_noproj(), and get_dim_stride()

087779c

Added draft version of get_dim_logical_stride and testing for sizes w…

77cab03

…ith projected dimensions

1. Renamed start_,end_ slice members to m_start and m_end.

322ff1b

2. Replaced camp::array usage with std::array. 3. Fixed and simplified get_dim_stride and get_parent_dim_stride. 4. Replaced usage of IndexType with size_t where appropriate.

gberg617 commented Mar 5, 2026

View reviewed changes

gberg617 added 2 commits March 5, 2026 14:43

added HIP subview test

d93b981

added HIP test and finished removing camp::array

5fb6dd0

gberg617 force-pushed the feature/bergel1/subview branch from 7323aa3 to 5fb6dd0 Compare March 5, 2026 23:17

attempt to revert camp submodule to release branch

be6df15

gberg617 force-pushed the feature/bergel1/subview branch from 0c1e1dc to be6df15 Compare March 5, 2026 23:20

Conversation

gberg617 commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

gberg617 commented Sep 19, 2025

Uh oh!

Uh oh!

Uh oh!

MrBurmark Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

MrBurmark Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

gberg617 Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

gberg617 Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gberg617 Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gberg617 commented Oct 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gberg617 Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

gberg617 Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gberg617 commented Sep 19, 2025 •

edited

Loading