Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request fixes the CUDA build system so that LULESH can be reliably built using modern NVCC and MPI toolchains. The previous Makefile had several issues that prevented correct compilation and linking when CUDA and MPI were used together.
Summary of Changes
mpicxx --showme:compileand--showme:link*.cusource filesResult
The project now builds successfully using:
cd cuda/build make mpirun -np 8 ./lulesh -s 90 -i 3145Tested on 8 * NVIDIA RTX 4090 with:
Notes
This PR does not modify application behavior or CUDA kernels, only the build system.