Skip to content

Conversation

@rhdedgar
Copy link
Collaborator

@rhdedgar rhdedgar commented Oct 3, 2025

Adding features.operators.openshift.io/fips-compliant: "true" annotation to the CSV as per the FIPS Operator checklist.

Closes RHAIENG-1325.

@derekhiggins
Copy link
Collaborator

This appears to be openshift specific, I wonder if it should only be in midstream only, although we already have openshift annotations in here so maybe its ok?

@rhdedgar
Copy link
Collaborator Author

Hi, I'm ok either way, it should be a no-op for most purposes upstream. Though the config/manifests/bases/llama-stack-k8s-operator.clusterserviceversion.yaml file gets created when building the operator. It's unused, as far as I can tell, so this just adds the label to that CSV when it does get created.

@VaishnaviHire
Copy link
Collaborator

Maybe we just add this in overlays for midstream, since the csv is not part of deployment by default?

@VaishnaviHire
Copy link
Collaborator

@mergify rebase

@mergify
Copy link

mergify bot commented Oct 28, 2025

rebase

✅ Branch has been successfully rebased

@VaishnaviHire VaishnaviHire force-pushed the fips-compliant-annotation branch from da72492 to d8f972f Compare October 28, 2025 15:04
@VaishnaviHire
Copy link
Collaborator

Maybe we just add this in overlays for midstream, since the csv is not part of deployment by default?

/lgtm for this change. But as mentioned here, need to add them in midestream overlays

@rhdedgar
Copy link
Collaborator Author

The e2e tests are failing due to a known issue I'm working on in RHAIENG-1655. The upstream run.yaml config has new requirements, and the example files and e2e test process needs to be updated to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants