-
Notifications
You must be signed in to change notification settings - Fork 119
feat: metrics #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anunaym14
wants to merge
11
commits into
main
Choose a base branch
from
feat/metrics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: metrics #629
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a7612c4
feat(metrics): initial impl
anunaym14 2d21bfe
try: ffi for metrics
anunaym14 6491025
fix: ffi build
anunaym14 7dded2d
try: fix ios missing symbols
anunaym14 5b66474
try: android: fix missing bits/libc-header-start.h
anunaym14 4e93e53
try2
anunaym14 cd8c637
Update builds.yml
cloudwebrtc 8a4a5b1
Update builds.yml
cloudwebrtc 2cbf3d0
Update builds.yml
cloudwebrtc fd33fe8
pr comments
anunaym14 c6c5b17
chore: fmt
anunaym14 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -839,6 +839,35 @@ impl RoomInner { | |
| pub fn url(&self) -> String { | ||
| self.url.clone() | ||
| } | ||
|
|
||
| pub fn publish_metrics( | ||
| self: &Arc<Self>, | ||
| server: &'static FfiServer, | ||
| publish: proto::PublishMetricsRequest, | ||
| ) -> FfiResult<proto::PublishMetricsResponse> { | ||
| let async_id = publish.async_id.unwrap_or_else(|| server.next_id()); | ||
|
|
||
| let data = unsafe { | ||
| slice::from_raw_parts(publish.data_ptr as *const u8, publish.data_len as usize) | ||
| } | ||
| .to_vec(); | ||
|
|
||
| let self_clone = self.clone(); | ||
| let handle = server.async_runtime.spawn(async move { | ||
| if let Err(err) = self_clone.data_tx.send(FfiDataPacket { | ||
| payload: DataPacket { | ||
| payload: data.to_vec(), // Avoid copy? | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. assuming this PR is still active, can we address the comment to avoid the copy here ? |
||
| ..Default::default() | ||
| }, | ||
| async_id, | ||
| }) { | ||
| log::error!("Failed to publish metrics: {:?}", err); | ||
| } | ||
| }); | ||
| server.watch_panic(handle); | ||
|
|
||
| Ok(proto::PublishMetricsResponse { async_id }) | ||
| } | ||
| } | ||
|
|
||
| // Task used to publish data without blocking the client thread | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it copy the data here ?