-
Notifications
You must be signed in to change notification settings - Fork 219
Update gradle dependencies #1207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate
wants to merge
1
commit into
main
Choose a base branch
from
renovate/gradle-dependencies
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+7
−7
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
livekit-uniffi/support/android/gradle/wrapper/gradle-wrapper.properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
webrtc-sys/libwebrtc/prefixed-jni/gradle/wrapper/gradle-wrapper.properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| #Thu Apr 29 14:50:17 JST 2021 | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.6.1-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.7.0-bin.zip | ||
| distributionPath=wrapper/dists | ||
| zipStorePath=wrapper/dists | ||
| zipStoreBase=GRADLE_USER_HOME |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Android library build can fail because the Kotlin toolchain is too old for the newly upgraded libraries
The Android library keeps the old Kotlin build plugin (
org.jetbrains.kotlin.androidversion "1.9.25" atlivekit-uniffi/support/android/build.gradle.kts:6) while its libraries are bumped to versions produced by a much newer Kotlin, so the packaged Android artifact can stop building.Impact: The Android release job may fail, blocking publishing of the Android package.
Kotlin metadata / AGP compatibility mismatch
kotlinx-coroutines-core:1.11.0(livekit-uniffi/support/android/build.gradle.kts:64) is compiled with Kotlin 2.2.20, andandroidx.annotation:annotation:1.10.0(livekit-uniffi/support/android/build.gradle.kts:62) is likewise built with a Kotlin 2.x toolchain. The Kotlin 1.9.x compiler only accepts binary metadata up to version 2.0, so compiling the generated UniFFI Kotlin sources (wired in atlivekit-uniffi/support/android/build.gradle.kts:52-58) against these artifacts typically fails with "was compiled with an incompatible version of Kotlin. The binary version of its metadata is 2.2.0, expected version is 1.9.0".Additionally, AGP is jumped from 8.2.2 to 8.13.2 (
livekit-uniffi/support/android/build.gradle.kts:5) while Kotlin Gradle Plugin 1.9.25 predates and was never tested against AGP 8.13; the usual supported pairing for AGP 8.13 is KGP 2.x. Bumping the Kotlin plugin to 2.x (and verifyingcompileSdk) alongside these dependency updates would keep the build consistent.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.