Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR reverts PR #15 which added FML syntax validation endpoint functionality with detailed error reporting. The revert removes all syntax validation features that were previously implemented.
- Removes the FML syntax validation endpoint and related functionality
- Deletes comprehensive test suites for validation features
- Removes type definitions and implementation for syntax validation
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/fmlrunner/tsconfig.json | Reverts exclusion of Kotlin bridge files from TypeScript compilation |
| packages/fmlrunner/tests/fml-syntax-validation.test.ts | Removes comprehensive test suite for FML syntax validation |
| packages/fmlrunner/src/types/index.ts | Removes type definitions for FML syntax validation interfaces |
| packages/fmlrunner/src/lib/fml-compiler.ts | Removes validateSyntax method and related helper functions |
| packages/fmlrunner/src/index.ts | Removes validateFmlSyntax method from FmlRunner class |
| packages/fmlrunner-rest/tests/fml-syntax-validation-api.test.ts | Removes REST API test suite for syntax validation endpoint |
| packages/fmlrunner-rest/src/api.ts | Removes validateFmlSyntax endpoint implementation |
| packages/fmlrunner-mcp/src/index.ts | Removes MCP tool for FML syntax validation |
| docs/FML_SYNTAX_VALIDATION.md | Removes documentation for syntax validation feature |
| demo.html | Removes demo page showcasing syntax validation functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #15