perf: added evm_snapshot in order to avoid deploying on beforeEach#621
Open
AlanVerbner wants to merge 3 commits intoliquity:mainfrom
Open
perf: added evm_snapshot in order to avoid deploying on beforeEach#621AlanVerbner wants to merge 3 commits intoliquity:mainfrom
AlanVerbner wants to merge 3 commits intoliquity:mainfrom
Conversation
AlanVerbner
force-pushed
the
chore/improve-contracts-test-speed
branch
from
6cd2be4 to
8ed1025
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The contracts tests take several minutes to run. This PR tries to tackle a low hanging fruit that helps improving such time.
Proposed solution
In order to speed up the tests I've replaced several contracts deployment executions that were ran before each test by
buidlervmevm_snapshotfeature (it works on ganache as well).At least on GH actions is taking
~25minstead of the~35-40mseen on the main repo, leading to a 30% reduction