-
-
Notifications
You must be signed in to change notification settings - Fork 275
Gandi.net API key is deprecated in favor of Gandi.net Personal Access Token (PAT) #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! Be sure to follow the pull request template!
I am a bot, here is the pushed image/manifest for this PR:
|
I am a bot, here is the pushed image/manifest for this PR:
|
I am a bot, here is the pushed image/manifest for this PR:
|
I am a bot, here is the pushed image/manifest for this PR:
|
I am a bot, here is the pushed image/manifest for this PR:
|
I am a bot, here is the pushed image/manifest for this PR:
|
I am a bot, here is the pushed image/manifest for this PR:
|
Description:
(Re)enable the support of the Gandi API Personal Access Token (PAT) for the Gandi DNS plugin located at
root/defaults/dns-conf/gandi.ini
with the correct name of the variable used in Gandi Certbot plugin on which this project depends.Actually in
root/defaults/dns-conf/gandi.ini
:but that has to be changed to:
Since linuxserver/docker-swag no longer work with the old
dns_gandi_api_key
variable in gandi.ini file, as it refers to the Gandi API Key authentication method, which is obsolete.dns_gandi_token
is the correct variable used with Gandi PAT in the Gandi Certbot Plugin.Benefits of this PR and context:
Before this change, the Gandi Certbot plugin accepted both the Gandi API key and the Gandi personal access token. Now, only the personal access token is supported by the Gandi Certbot plugin.
Linked issues : #426
How Has This Been Tested?
After having issues when I would like to setup a new instance of docker-swag with a Gandi domain + DNS challenge. I tried to understand how the Gandi Certbot plugin works and I found in this in the documentation of Gandi Certbot Plugin repo :

I replaced the variable name by
dns_gandi_api_key=*******
in and I no longer have any problems. The certificate has been issued.Source / References: