Fix about links #459
Open
Fix about links #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygerlach
commented
Oct 6, 2025
Comment on lines
-61
to
-67
|
|
||
| int uid = -1; | ||
| string cmd = "id -u"; | ||
| string std_out, std_err; | ||
| exec_sync(cmd, out std_out, out std_err); | ||
| if ((std_out != null) && (std_out.length > 0)){ | ||
| uid = int.parse(std_out); |
Contributor
Author
There was a problem hiding this comment.
This subprocess could have been a syscall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #457
I now overwrite the default behavior of the
AboutDialogwith our ownxdg_open, that uses thesudoorpkexeccalling user to drop into his environment.I am currently guessing the
DBUS_SESSION_BUS_ADDRESS(firefox seems to need this to find its open processes). Maybe it would be a good idea to copy the entire env from the parent of pkexec or sudo, when using xdg-open.I have also removed some unused user functions, as they can be largely reimplemented with a single line of
Posix.getpwuid(uid)?.pw_diror similar if we ever need something like that again.