Fix:pdf url access error#21
Merged
deepin-bot[bot] merged 2 commits intolinuxdeepin:develop/eaglefrom Nov 24, 2025
Merged
Conversation
Log: as title Bug: https://pms.uniontech.com/bug-view-341615.html
Log: update the baseline version to 1.0.3
|
TAG Bot TAG: 1.0.3 |
deepin pr auto review我来对这个 diff 进行审查:
改进建议:
const size_t MAX_URI_LENGTH = 2048;
char uri[MAX_URI_LENGTH] = {0};
unsigned long length = FPDFAction_GetURIPath(m_doc, action, uri, MAX_URI_LENGTH);
if (length > 0 && length < MAX_URI_LENGTH) {
dAnnot->setUrl(uri);
}
unsigned long length = FPDFAction_GetURIPath(m_doc, action, uri, MAX_URI_LENGTH);
std::string uri;
uri.resize(MAX_URI_LENGTH);
unsigned long length = FPDFAction_GetURIPath(m_doc, action, &uri[0], MAX_URI_LENGTH);
if (length > 0 && length < MAX_URI_LENGTH) {
uri.resize(length);
dAnnot->setUrl(uri);
}总体来说,这个修改是合理的,提高了代码的健壮性和安全性,但还可以通过上述建议进一步改进代码质量。 |
max-lvs
approved these changes
Nov 24, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LiHua000, max-lvs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cannot handle URLs longer than 256 characters.
bug: https://pms.uniontech.com/bug-view-341615.html