fix: [cppcheck] Improve code formatting for architecture mapping#533
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:develop/eaglefrom Sep 15, 2025
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReformatted static QMap initializations for architecture mapping and aligned declaration of error string map to improve code readability and maintain consistent styling. Class diagram for updated QMap initializationsclassDiagram
class commonfunction {
+static QMap<QString, QString> mapArch
}
class commontools {
+static QMap<DriverType, QString> m_MapDriverType
+static QMap<Status, QString> m_MapStatusIcon
+static QMap<Status, QString> m_MapStatusType
+static QMap<int, QString> m_MapErrorString
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Enhanced readability of the architecture mapping table by reformatting the static QMap initialization with proper indentation and line breaks. also add comments for variables. Log: Refactor architecture mapping code style Change-Id: Iea19f9e13e7b8f59f66d34877e555994832a0221
838f173 to
b4bbe0c
Compare
deepin pr auto review根据提供的git diff内容,我将从代码质量、语法逻辑、性能和安全性等方面进行分析并提出改进建议:
总的来说,这些修改主要是关于代码格式、注释和变量命名的改进,这些改动有助于提高代码的可读性和可维护性。同时,也发现了一些潜在的问题,如变量拼写错误和可能的性能问题,建议在后续开发中加以注意和改进。 |
max-lvs
approved these changes
Sep 15, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos, max-lvs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced readability of the architecture mapping table by reformatting the static QMap initialization with proper indentation and line breaks.
Log: Refactor architecture mapping code style
Change-Id: Iea19f9e13e7b8f59f66d34877e555994832a0221
Summary by Sourcery
Reformat static QMap initializations across source and header files to enhance readability and maintain a consistent code style.
Enhancements: