fix: add input device bus interface for USB Devices#528
fix: add input device bus interface for USB Devices#528deepin-bot[bot] merged 1 commit intolinuxdeepin:develop/eaglefrom
Conversation
improve input device Bus interface detectionadd, add input device bus interface for USB Devices Log: add input device bus interface for USB Devices Bug: https://pms.uniontech.com/bug-view-331181.html Change-Id: Ie66f434275af797a31a083f9ea6eb8a63dd427ab
Reviewer's guide (collapsed on small PRs)Reviewer's GuideExtended input device bus interface detection by including USB devices in the supported interfaces list. Class diagram for updated DeviceInput supported interfacesclassDiagram
class DeviceInput {
+QStringList m_supportInterfaces
}
DeviceInput : m_supportInterfaces = ["PS/2", "Bluetooth", "I2C", "USB"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review根据提供的git diff,我看到在DeviceInput.cpp文件中,对m_supportInterfaces列表进行了一个简单的修改,添加了"USB"接口支持。让我对这个修改进行分析:
改进建议:
static const QStringList SUPPORTED_INTERFACES = {"PS/2", "Bluetooth", "I2C", "USB"};
总体来说,这个修改本身是简单且安全的,但建议配合相关的USB设备处理逻辑一起完善,并考虑上述改进建议以提高代码质量和可维护性。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos, GongHeng2017, max-lvs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: unstable) |
45383ea
into
linuxdeepin:develop/eagle
improve input device Bus interface detectionadd, add input device bus interface for USB Devices
Log: add input device bus interface for USB Devices
Bug: https://pms.uniontech.com/bug-view-331181.html
Change-Id: Ie66f434275af797a31a083f9ea6eb8a63dd427ab
Summary by Sourcery
Bug Fixes: