Skip to content

fix: remove unused poppler in dde-grand-search.spec#77

Open
felixonmars wants to merge 2 commits intolinuxdeepin:masterfrom
felixonmars:patch-2
Open

fix: remove unused poppler in dde-grand-search.spec#77
felixonmars wants to merge 2 commits intolinuxdeepin:masterfrom
felixonmars:patch-2

Conversation

@felixonmars
Copy link
Member

It's no longer in use.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: felixonmars

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link

deepin-bot bot commented Apr 24, 2024

TAG Bot

New tag: 5.4.8
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #89

@deepin-bot
Copy link

deepin-bot bot commented Apr 25, 2024

TAG Bot

New tag: 5.4.9
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #90

@deepin-bot
Copy link

deepin-bot bot commented Jun 13, 2024

TAG Bot

New tag: 5.5.0
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #97

@deepin-bot
Copy link

deepin-bot bot commented Aug 7, 2024

TAG Bot

New tag: 5.5.1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #108

@deepin-bot
Copy link

deepin-bot bot commented Aug 12, 2024

TAG Bot

New tag: 5.5.2
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #111

@deepin-bot
Copy link

deepin-bot bot commented Sep 20, 2024

TAG Bot

New tag: 5.5.4
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #121

@deepin-bot
Copy link

deepin-bot bot commented Oct 31, 2024

TAG Bot

New tag: 5.5.6
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #147

@deepin-bot
Copy link

deepin-bot bot commented Nov 1, 2024

TAG Bot

New tag: 5.5.7
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #151

@deepin-bot
Copy link

deepin-bot bot commented Dec 14, 2024

TAG Bot

New tag: 5.5.8
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #159

@deepin-bot
Copy link

deepin-bot bot commented Dec 16, 2024

TAG Bot

New tag: 5.5.10
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #160

@deepin-bot
Copy link

deepin-bot bot commented Dec 19, 2024

TAG Bot

New tag: 5.5.11
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #165

@deepin-bot
Copy link

deepin-bot bot commented Jan 20, 2025

TAG Bot

New tag: 6.0.0
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #179

@deepin-bot
Copy link

deepin-bot bot commented Jan 21, 2025

TAG Bot

New tag: 6.0.1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #181

@deepin-bot
Copy link

deepin-bot bot commented Jan 22, 2025

TAG Bot

New tag: 6.0.2
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #184

@deepin-bot
Copy link

deepin-bot bot commented Feb 14, 2025

TAG Bot

New tag: 6.0.3
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #185

@deepin-bot
Copy link

deepin-bot bot commented Feb 27, 2025

TAG Bot

New tag: 6.0.4
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #187

@deepin-bot
Copy link

deepin-bot bot commented Mar 6, 2025

TAG Bot

New tag: 6.0.5
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #190

@deepin-bot
Copy link

deepin-bot bot commented Mar 27, 2025

TAG Bot

New tag: 6.0.6
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #194

@deepin-bot
Copy link

deepin-bot bot commented Apr 2, 2025

TAG Bot

New tag: 6.0.7
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #197

@deepin-bot
Copy link

deepin-bot bot commented Apr 10, 2025

TAG Bot

New tag: 6.0.8
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #200

@deepin-bot
Copy link

deepin-bot bot commented Apr 10, 2025

TAG Bot

New tag: 6.0.9
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #201

@deepin-bot
Copy link

deepin-bot bot commented May 20, 2025

TAG Bot

New tag: 6.0.10
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #213

@deepin-bot
Copy link

deepin-bot bot commented May 21, 2025

TAG Bot

New tag: 6.0.11
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #216

@deepin-bot
Copy link

deepin-bot bot commented May 29, 2025

TAG Bot

New tag: 6.0.12
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #219

@deepin-bot
Copy link

deepin-bot bot commented Jun 13, 2025

TAG Bot

New tag: 6.0.13
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #220

@deepin-bot
Copy link

deepin-bot bot commented Jun 23, 2025

TAG Bot

New tag: 6.0.14
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #224

@deepin-bot
Copy link

deepin-bot bot commented Jun 23, 2025

TAG Bot

New tag: 6.0.15
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #225

@deepin-bot
Copy link

deepin-bot bot commented Jun 26, 2025

TAG Bot

New tag: 6.0.16
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #227

@deepin-bot
Copy link

deepin-bot bot commented Jun 27, 2025

TAG Bot

New tag: 6.0.17
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #231

@deepin-bot
Copy link

deepin-bot bot commented Jul 1, 2025

TAG Bot

New tag: 6.0.18
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #239

@deepin-bot
Copy link

deepin-bot bot commented Jul 3, 2025

TAG Bot

New tag: 6.0.19
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #241

@deepin-bot
Copy link

deepin-bot bot commented Jul 10, 2025

TAG Bot

New tag: 6.0.20
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #244

@deepin-bot
Copy link

deepin-bot bot commented Aug 8, 2025

TAG Bot

New tag: 6.0.21
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #248

@deepin-bot
Copy link

deepin-bot bot commented Aug 14, 2025

TAG Bot

New tag: 6.0.22
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #251

@deepin-bot
Copy link

deepin-bot bot commented Sep 1, 2025

TAG Bot

New tag: 6.0.23
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #252

@deepin-bot
Copy link

deepin-bot bot commented Sep 4, 2025

TAG Bot

New tag: 6.0.24
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #255

@deepin-bot
Copy link

deepin-bot bot commented Sep 22, 2025

TAG Bot

New tag: 6.0.25
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #257

@github-actions
Copy link

CLA Assistant Lite bot:

如果你是以企业贡献者的身份进行提交,请联系我们签署企业贡献者许可协议
If you submit as corporate contributor, please contact us to sign our Corporate Contributor License Agreement

感谢您的提交,我们非常感谢。 像许多开源项目一样,在接受您的贡献之前,我们要求您签署我们的个人贡献者许可协议。 您只需发布与以下格式相同的评论即可签署个人贡献者许可协议
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Individual Contributor License Agreement before we can accept your contribution. You can sign the Individual Contributor License Agreement by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA.

1 out of 2 committers have signed the CLA.
@felixonmars
@lzwind
You can retrigger this bot by commenting recheck in this Pull Request

@deepin-ci-robot
Copy link

deepin pr auto review

我来帮你分析这个git diff修改。这是一个针对dde-grand-search软件包的spec文件修改。

  1. 语法逻辑:

    • 修改的语法完全正确,只是移除了两个依赖项的声明
    • 格式保持一致,缩进和空格都符合规范
  2. 代码质量:

    • 移除了不必要的依赖项,这是一个好的实践
    • 同时移除了BuildRequires和Requires中的poppler-qt5,保持了一致性
    • 修改后的依赖列表更加精简和准确
  3. 代码性能:

    • 移除不必要的依赖可以:
      • 减少编译时的依赖检查时间
      • 减小最终安装包的大小
      • 降低运行时的内存占用
  4. 代码安全:

    • 减少依赖项可以降低潜在的安全风险
    • 每减少一个依赖就减少了一个可能的安全漏洞来源

改进建议:

  1. 在提交这种更改时,建议在提交信息中说明为什么移除这些依赖,例如:

    • "移除poppler-qt5依赖,因为该功能已不再使用"
    • 或者 "通过重构代码,不再需要poppler-qt5库"
  2. 建议在spec文件中添加注释说明移除这些依赖的原因,这样其他维护者在未来查看时能更好地理解这个决定。

  3. 如果这次移除依赖是某个更大重构的一部分,建议在PR中引用相关的issue或任务编号。

总的来说,这是一个很好的改进,通过移除不必要的依赖来优化软件包。只要确保移除这些依赖不会影响软件的核心功能,这个修改就是合理且有益的。

@deepin-bot
Copy link

deepin-bot bot commented Dec 18, 2025

TAG Bot

New tag: 6.0.26
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #264

@deepin-bot
Copy link

deepin-bot bot commented Dec 25, 2025

TAG Bot

New tag: 6.0.27
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #268

@deepin-bot
Copy link

deepin-bot bot commented Dec 26, 2025

TAG Bot

New tag: 6.0.28
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #269

@deepin-bot
Copy link

deepin-bot bot commented Jan 29, 2026

TAG Bot

New tag: 6.0.29
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants