Fix time range tests by aligning assertions with timezone #13237
+17
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venkymano-akamai
approved these changes
Jan 1, 2026
Collaborator
Cloud Manager UI test results🎉 870 passing tests on test run #3 ↗︎
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes flaky time-range tests by correcting timezone handling in date comparisons. The tests were incorrectly comparing UI wall-clock times (user timezone) with API payloads (UTC), causing failures in CI.
Key Changes:
- Modified
getThisMonthRange()andgetLastMonthRange()functions to accept a timezone parameter and properly convert to UTC - Changed mock profile timezone from 'UTC' to 'America/New_York' to test timezone conversion logic
- Updated test assertions to use the mock profile's timezone when generating expected date ranges
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/manager/cypress/e2e/core/cloudpulse/timerange-verification.spec.ts | Refactored date range functions to accept timezone parameter and convert to UTC; updated mock profile timezone and test calls |
| packages/manager/.changeset/pr-13237-tests-1767269372512.md | Added changeset documenting the test fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This change fixes flaky time-range tests by correcting how date and time values are validated.
The tests were incorrectly comparing UI wall-clock times (user timezone) with API payloads (UTC), which caused consistent failures in CI and incorrect assumptions about application behavior.
Changes 🔄
List any change(s) relevant to the reviewer.
-Removed invalid UI-to-UTC time comparisons.
Updated preset tests (This Month, Last Month, custom ranges) to asser
How to test 🧪
pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts,cypress/e2e/core/cloudpulse/timerange-verification.spec.ts"
Prerequisites
(How to setup test environment)
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support