Skip to content

Conversation

@ankita-akamai
Copy link
Contributor

@ankita-akamai ankita-akamai commented Dec 31, 2025

Description 📝

Add edit feature for notification channels.

Changes 🔄

  • Add form component with react-hook-form integration for editing channel name and recipients, includes validation and error handling
  • Add landing page component that fetches channel data by ID and renders EditNotificationChannel with loading/error states.
  • Add new route /alerts/notification-channels/edit/$channelId with lazy loading
  • Add filterEditChannelFormValues utility to transform form data to API payload format
  • Add schemas, test cases, update mocks.

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

13 jan 2026

Preview 📷

image

How to test 🧪

Verification steps

[Verify in mock env]

  • Navigate to channels tab under monitor.
  • Click on edit action (three dots in the table row) on any notification channel.
  • Verify edit form loads with pre-filled channel data
  • Verify that these filters are visible - Type, Name, and Recipients.
  • Verify that the type filter is disabled and a channel type is default selected.
  • Verify that 'name' filter is editable.
  • Verify that 'recipients' filter is editable.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@ankita-akamai ankita-akamai marked this pull request as ready for review December 31, 2025 16:45
@ankita-akamai ankita-akamai requested a review from a team as a code owner December 31, 2025 16:45
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing868 Passing11 Skipped45m 22s

Details

Failing Tests
SpecTest
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page
timerange-verification.spec.tsCloud Manager Cypress Tests→Integration tests for verifying Cloudpulse custom and preset configurations » should implement and validate custom date/time picker for a specific date and time range

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts,cypress/e2e/core/cloudpulse/timerange-verification.spec.ts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

3 participants