Skip to content

Conversation

@venkymano-akamai
Copy link
Contributor

@venkymano-akamai venkymano-akamai commented Dec 30, 2025

Description 📝

Add New feature marker in navigation menu and primary breadcrumbs of CloudPulse metrics

Changes 🔄

  • LD flag to control to show the new feature chip
  • Integrate the new feature chip in primary navigation
  • Integrate the new feature chip in CloudPulse metrics landing page

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️ Next Release

Preview 📷

Before After
Screenshot 2025-12-30 at 11 19 59 AM Screenshot 2025-12-30 at 11 20 25 AM

How to test 🧪

  1. Login in to Cloud Manager application
  2. From the new dev tools feature flags under cloudpulse enable new
  3. You should see new marker in Metrics under Monitor in primary navigation
  4. Once you click on metrics, you should see New marker in breadcrumbs
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@venkymano-akamai venkymano-akamai marked this pull request as ready for review December 30, 2025 06:24
@venkymano-akamai venkymano-akamai requested a review from a team as a code owner December 30, 2025 06:24
Copy link
Contributor

@santoshp210-akamai santoshp210-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Dec 31, 2025
Copy link
Contributor

@pmakode-akamai pmakode-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.

This is not a blocker, but I wanted to point out that toggling the flag from DevTools for the CloudPulse feature-related Chips does not immediately reflect in the PrimaryNav unless I reload the page/app, although the Breadcrumb Suffix Feature Chip works as expected. Other features, like IAM in PrimaryNav, work as expected.

See
Screen.Recording.2026-01-01.at.2.32.32.PM.mov

Approving pending resolution of the one minor comment I left.

hide: !isACLPEnabled,
to: '/metrics',
isBeta: flags.aclp?.beta,
isNew: flags.aclp?.new,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add a condition similar to L279 -- show the new feature chip only when the beta flag is not enabled, to avoid potentially displaying two chips at the same time, like this:

Image

@venkymano-akamai venkymano-akamai removed the request for review from bnussman-akamai January 1, 2026 09:30
@venkymano-akamai venkymano-akamai added the Approved Multiple approvals and ready to merge! label Jan 1, 2026
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing868 Passing11 Skipped44m 10s

Details

Failing Tests
SpecTest
vpc-linodes-update.spec.tsCloud Manager Cypress Tests→VPC assign/unassign flows » can assign Linode(s) to a VPC
vpc-linodes-update.spec.tsCloud Manager Cypress Tests→VPC assign/unassign flows » can assign a Linode without auto-assigning an IPv4 to a VPC

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/vpc/vpc-linodes-update.spec.ts"

@venkymano-akamai
Copy link
Contributor Author

venkymano-akamai commented Jan 1, 2026

merging this, since it has enough approvals and cypress is unrelated

The minor comment from @pmakode-akamai is also addressed

@venkymano-akamai venkymano-akamai merged commit 1ba4648 into linode:develop Jan 1, 2026
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Cloud Pulse - Dashboards Cloud Pulse

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

5 participants