Fix test for interfaces #605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliang-akamai
requested review from
jriddle-linode and
lgarber-akamai
and removed request for
a team
ezilber-akamai
approved these changes
Sep 30, 2025
lgarber-akamai
approved these changes
Sep 30, 2025
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
zliang-akamai
added
testing
srbhaakamai
pushed a commit
to srbhaakamai/linode_api4-python
that referenced
this pull request
Oct 3, 2025
srbhaakamai
added a commit
to srbhaakamai/linode_api4-python
that referenced
this pull request
Oct 3, 2025
yec-akamai
added a commit
that referenced
this pull request
Dec 2, 2025
* DI-26927 Python SDK code for GET Alert Definitions * DI-26927 Python SDK code modified for client code * DI-26927 Added Unit test cases and missing classes * DI-26927 made corrections to keep code consistent * DI-26927 Updated Unit and Integratoion Tests * [dev 51950af] DI-26927 Updated Unit and Integratoion Tests * Revert "DI-26927 Updated Unit and Integratoion Tests" This reverts commit 51950af. * Revert "[dev 51950af] DI-26927 Updated Unit and Integratoion Tests" This reverts commit 6ca6a5a. * DI-26927 Updated Unit and Integratoion Tests * Remove .venv from repo and add to .gitignore * DI-26927 reverted git ignore * DI-26927 reverted conftest,py * DI-26927 added accidentlly deleted file * DI-26927 Corrected Integration and Unit Test cases for Alerting APIs * DI-26927 Reverted conftest.py and check integration without those changes * DI-26927 fixed integration test for firewall and added time for alert update before deletion * DI-26927 fixed changing monitor.py as per review comments * DI-26927 fixed changing monitor.py as per review comments * DI-26927 fixed changing monitor.py as per review comments * DI-26927 Intermediate change to address internal review comments * DI-26927 CLosed review comments * DI-26927 CLosed review comments * DI-27156 closed review comments from Ketan * DI-27156 closed review comments from Ketan * DI-27156 fixed unit test cases post review comments fixes * DI-27156 Updated docstring and make unit test cases changes * DI-27156 Added unit test cases post review comments fixes * DI-27156 Added unit test cases post review comments fixes * tests(monitor): add MonitorAlertDefinitionsTest and update fixtures for alert-definitions * DI-27156 Added unit test cases post review comments fixes * DI-27156 Updated docstring * DI-27156 Updated unit test errors * removed unwanted files * added missing doxcstring * added missing doxcstring * added missing doxcstring * rmoved test files * closed final review comments * fixing integration test issues * Corrected Integration Test Case * DI-26927 Corrected json to object modifications issues * DI-26927 Corrected json to object modifications issues * DI-26927 Unit test corrections for mofied functions name * Delete test/fixtures/monitor/services/dbaas/alert-definitions.json Not Required * Delete test.py Not Required here required for local testing only * Delete test/fixtures/monitor/alert-definitions.json Not required here * DI-26927 reverted fixtures.py as its not necesary to change * DI-26927 reverted fixtures.py as its not necesary to change * DI-26927 reverted fixtures.py as its not necesary to change * DI-26927 fixed linting error * DI-26927 fixed linting error * DI-26927 fixed lint error caught in CI * Update test/unit/groups/monitor_api_test.py Co-authored-by: Copilot <[email protected]> * Update test/integration/models/monitor/test_monitor.py Co-authored-by: Copilot <[email protected]> * Update test/integration/models/monitor/test_monitor.py Co-authored-by: Copilot <[email protected]> * Update test/integration/models/monitor/test_monitor.py Co-authored-by: Copilot <[email protected]> * Update linode_api4/objects/monitor.py Co-authored-by: Copilot <[email protected]> * DI-26927 fixed copilot comments * fixed review comments from APIv4 team * fixed review comments from APIv4 team * fixed review comments from APIv4 team * fixed review comments from APIv4 team * DI-26927 fixed review comments from API v4 team * fixed review comments from APIv4 team * fixed lint errors * Update linode_api4/groups/monitor.py Co-authored-by: Ye Chen <[email protected]> * Update linode_api4/groups/monitor.py Co-authored-by: Ye Chen <[email protected]> * fixed review errors * fixed unittest * fixed unittest * fixed unittest * fixed unittest * fixed unittest * fixed unittest * added update use case to integration test * Update linode_api4/objects/monitor.py Co-authored-by: Ye Chen <[email protected]> * Update linode_api4/objects/monitor.py Co-authored-by: Ye Chen <[email protected]> * Update linode_api4/objects/monitor.py Co-authored-by: Ye Chen <[email protected]> * Update linode_api4/objects/monitor.py Co-authored-by: Ye Chen <[email protected]> * fixed further review comments * Updated integration test * Updated integration test with more assert statements * Fix Linode interfaces property (#604) * Fix test for interfaces (#605) * Fix test * changed as per github-advanced-security comments * fixed formatting errors using python black * Migrate test fixtures discovery to be with pathlib (#599) * Migrate test fixtures discovery to be with pathlib * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> * Update linode_api4/objects/monitor.py Co-authored-by: Ye Chen <[email protected]> * Fixed Copilot comments on unit and integration tests * corrected unit test assert statement * Added comment as per copilot suggestion for save() and delete() * resolved comments from copilot commented whereever not applicable * Test: verify automatic GPG signing is working * Incorporated copilot comments * Removed serialisabel file from commit * Fix Lint errors * fixed review comments fo mutable * fixed review comments to keep it in line with SDK guidelines * Addressed review comments on AlertDefinition class * Comprehensive monitor API improvements and code quality fixes - Removed unused imports and optimized import order - Updated test cases for monitor integration - Enhanced monitor objects with proper type annotations - Improved monitor groups with better error handling - Applied code review feedback and best practices * Applied review comments across * Comprehensive monitor API fixes and improvements - Fixed json_object parameter issues in AlertDefinition properties - Corrected list type annotations for AlertChannelEnvelope - Updated integration tests with proper status handling for alert definitions - Applied review comments for better code quality - Enhanced type annotations and import organization - Improved error handling in monitor group methods * change entity id type as per review comments * reverted copilot comments as per the suggestion unit and integration test passed after the changes * removed unused imports * removed unused imports * Refactored integration test * changed _class to alert_class as per review suggestions * changed alert_class to service_class as per review suggestions * Update linode_api4/objects/monitor.py * Update test/integration/models/monitor/test_monitor.py Co-authored-by: Copilot <[email protected]> * Update test/integration/models/monitor/test_monitor.py Co-authored-by: Copilot <[email protected]> * Update linode_api4/groups/monitor.py Co-authored-by: Copilot <[email protected]> * Update test/integration/models/monitor/test_monitor.py Co-authored-by: Copilot <[email protected]> * Update linode_api4/groups/monitor.py Co-authored-by: Copilot <[email protected]> * Update test/fixtures/monitor_alert-definitions.json * Apply suggestion from @zliang-akamai * Apply suggestion from @zliang-akamai --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Ye Chen <[email protected]> Co-authored-by: Zhiwei Liang <[email protected]> Co-authored-by: Zhiwei Liang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.