Skip to content

Fix Linode interfaces property #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zliang-akamai merged 5 commits into from
Sep 30, 2025
Merged

Fix Linode interfaces property #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f7de35a
Rename `interfaces` property to `linode_interfaces`
zliang-akamai Sep 29, 2025
3f52e9e
Return `None` when interface generation is not `linode`
zliang-akamai Sep 29, 2025
fb9c7eb
Update docstring
zliang-akamai Sep 29, 2025
796a314
Fix test
zliang-akamai Sep 30, 2025
2130c66
Use enum
zliang-akamai Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions linode_api4/objects/linode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2006,15 +2006,18 @@ def interfaces_settings(self) -> LinodeInterfacesSettings:
return self._interfaces_settings

@property
def interfaces(self) -> List[LinodeInterface]:
def linode_interfaces(self) -> Optional[list[LinodeInterface]]:
"""
All interfaces for this Linode.

API Documentation: https://techdocs.akamai.com/linode-api/reference/get-linode-interface

:returns: An ordered list of interfaces under this Linode.
:returns: An ordered list of linode interfaces under this Linode. If the linode is with legacy config interfaces, returns None.
:rtype: Optional[list[LinodeInterface]]
"""

if self.interface_generation != InterfaceGeneration.LINODE:
return None
if not hasattr(self, "_interfaces"):
result = self._client.get(
"{}/interfaces".format(Instance.api_endpoint),
Expand Down
2 changes: 1 addition & 1 deletion test/unit/objects/linode_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ def test_get_interfaces(self):

assert instance.interface_generation == InterfaceGeneration.LINODE

interfaces = instance.interfaces
interfaces = instance.linode_interfaces

LinodeInterfaceTest.assert_linode_124_interface_123(
next(iface for iface in interfaces if iface.id == 123)
Expand Down