Fix skip condition for database tests when RUN_DB_TESTS is unset #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykim-akamai
requested review from
lgarber-akamai and
yec-akamai
and removed request for
a team
lgarber-akamai
approved these changes
Feb 10, 2025
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Works well on my end, thanks for fixing this!
zliang-akamai
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Addressing issue below where RUN_DB_TESTS is required when running integration tests.
✔️ How to Test
Run smoke test without specifying RUN_DB_TESTS
make test-smoke📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.