fix: missing acl schema #888
Open
+23
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
based on the assumption that clusterDomainSuffix is always present in settings |
ferruhcihan
requested changes
Jan 7, 2026
Collaborator
ferruhcihan
left a comment
ferruhcihan
left a comment
There was a problem hiding this comment.
Overall, the approach looks good 👍 I just noticed that some tests are failing in workloadUtils.test.ts, and there’s a small improvement needed in the URL checks instead of exact match.
| : normalizeRepoUrl(repositoryUrl, isPrivate, isSSH) | ||
|
|
||
| const repoUrl = | ||
| repositoryUrl === `https://gitea.${cluster?.domainSuffix}` |
Collaborator
There was a problem hiding this comment.
This check would never match any actual repository URL and will cause all internal Gitea repositories to fail the equality check. For the URL check, we could use something like the following:
const isInternalGitea = (() => {
try {
const url = new URL(repositoryUrl)
return url.hostname === `gitea.${cluster?.domainSuffix}`
} catch {
return false
}
})()
const repoUrl = isInternalGitea
? repositoryUrl
: normalizeRepoUrl(repositoryUrl, isPrivate, isSSH)
j-zimnowoda
reviewed
Jan 7, 2026
| post: | ||
| operationId: getWorkloadCatalog | ||
| x-eov-operation-handler: v1/workloadCatalog | ||
| x-aclSchema: Workload |
Contributor
There was a problem hiding this comment.
Why schema is called workload if the resource is tWorkloadCatalog?
j-zimnowoda
reviewed
Jan 7, 2026
| if (!existsSync(localHelmChartsDir)) mkdirSync(localHelmChartsDir, { recursive: true }) | ||
| let gitUrl = helmChartCatalogUrl | ||
| if (isGiteaURL(helmChartCatalogUrl)) { | ||
| if (helmChartCatalogUrl === `https://gitea.${clusterDomainSuffix}`) { |
Contributor
There was a problem hiding this comment.
you could also rely on HELM_CHART_CATALOG env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracks this bug: https://track.akamai.com/jira/browse/APL-1412