feat: add TRUST_PROXY configuration for client IP detection #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CasLubbers
requested review from
dennisvankekem and
ferruhcihan
as code owners
Ani1357
approved these changes
Dec 29, 2025
j-zimnowoda
reviewed
Dec 29, 2025
src/validators.ts
Outdated
| }) | ||
| export const TRUST_PROXY = num({ | ||
| desc: 'Number of reverse proxies to trust for client IP detection (0 to disable, 1 for Kubernetes Ingress, 2 for LB + Ingress)', | ||
| default: 1, |
Contributor
There was a problem hiding this comment.
should default be 2 as there is nginx ingress and istio GW ?
We could also enforce it on the apl-core level
j-zimnowoda
approved these changes
Dec 29, 2025
Ani1357
pushed a commit
that referenced
this pull request
Jan 6, 2026
* feat: add TRUST_PROXY configuration for client IP detection * fix: set default to 2 --------- Co-authored-by: svcAPLBot <[email protected]> (cherry picked from commit fefb72b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.