Skip to content

vello_gpu: reuse staging belt for strips upload - #1915

Open
HigherOrderLogic wants to merge 1 commit into
linebender:mainfrom
HigherOrderLogic:gpu/staging
Open

HigherOrderLogic wants to merge 1 commit into
linebender:mainfrom
HigherOrderLogic:gpu/staging

Conversation

@HigherOrderLogic

Copy link
Copy Markdown
Contributor

Clear more TODO.

This remove the queue allocation and use an arena-like staging belt instead.

@LaurenzV

Copy link
Copy Markdown
Collaborator

Ah, sorry, I forgot to mention that there was a reason why we haven't used the wgpu-native staging belt, see this PR: #1532

Or does this problem not exist in this implementation?

@HigherOrderLogic

Copy link
Copy Markdown
Contributor Author

Or does this problem not exist in this implementation?

I think it should eliminate the overlapped memory problem, since the old belt is dropped every time a new one is created. However, there would still be overlapped memory spike, for example when frames are submitted too fast, but this should only last for a short duration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants