vello_gpu: reuse staging belt for strips upload - #1915
Open
HigherOrderLogic wants to merge 1 commit into
Open
HigherOrderLogic wants to merge 1 commit into
HigherOrderLogic wants to merge 1 commit into
Conversation
Collaborator
|
Ah, sorry, I forgot to mention that there was a reason why we haven't used the wgpu-native staging belt, see this PR: #1532 Or does this problem not exist in this implementation? |
Contributor
Author
I think it should eliminate the overlapped memory problem, since the old belt is dropped every time a new one is created. However, there would still be overlapped memory spike, for example when frames are submitted too fast, but this should only last for a short duration. |
HigherOrderLogic
force-pushed
the
gpu/staging
branch
from
September 15, 2026 08:25
ad5e1ad to
099c1ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear more TODO.
This remove the queue allocation and use an arena-like staging belt instead.