Conversation
This was referenced Aug 31, 2026
Quik2007
force-pushed
the
qos/atlas-drop-diagnostics
branch
from
August 31, 2026 15:27
2a88eea to
9f0c290
Compare
Quik2007
force-pushed
the
qos/atlas-drop-diagnostics
branch
3 times, most recently
from
September 1, 2026 06:47
491894f to
7efa877
Compare
Count image draws that resolution omits after atlas allocation fails and emit one renderer warning. Keep the signal diagnostic-only and rate-limit it over the cache lifetime.
Quik2007
force-pushed
the
qos/atlas-drop-diagnostics
branch
from
September 1, 2026 06:47
7efa877 to
a79561c
Compare
Quik2007
marked this pull request as ready for review
September 1, 2026 19:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
While debugging missing dynamic images, I found that Vello Classic silently omits an image draw when atlas allocation still fails after growing the atlas and evicting stale entries. The resolver uses no atlas location for that image and continues rendering, so the missing image has no visible explanation in the application log.
This can affect applications whose image set can exhaust the maximum atlas. Applications with small, fixed image sets are unlikely to encounter it.
Approach
Report the existing failure rather than change atlas allocation or attempt recovery. The renderer emits one warning on the first resolve pass that omits images. Later omissions are suppressed to avoid logging every affected frame.
This is limited to logging because the current renderer API has no structured diagnostic channel for this condition. It does not recover the image or let the application react programmatically.
Changes
The warning does not identify the affected image. It also cannot distinguish an image larger than the maximum atlas from an atlas occupied by other live images.
Testing
cargo test -p vello_encoding --lib --all-features --locked(32 passed)cargo test -p vello --lib --all-features --lockedPerformance impact
I found no measurable steady-state performance impact. I benchmarked the changed per-resolve bookkeeping in release mode on an AMD Ryzen 9 7940HS, pinned to one core. Each revision ran 200 million iterations in six alternating runs.
The median difference was 0.007 ns, or 0.46%, and the ranges overlap. This is below the resolution of the benchmark and is not evidence of a regression.
The benchmark covers the bookkeeping performed on every image resolve. It does not include the failure-only warning. Each omitted image adds two saturating integer increments; the first failing resolve also emits one log message. Logging is more expensive than the counters, but occurs only once per image-cache lifetime after atlas allocation has already failed.
AI usage: This PR was prepared with assistance from an AI coding tool.