Check that input is a tty before using it #4416
Open
+26
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anders F Björklund <[email protected]>
The current UI library will crash, if trying to read input from something that is not a terminal (a TTY). Signed-off-by: Anders F Björklund <[email protected]>
AkihiroSuda
reviewed
Dec 1, 2025
| // InputIsTTY returns true if reader is coming from stdin, and stdin is a terminal device, | ||
| // not a regular file, stream, or pipe etc. | ||
| func InputIsTTY(reader io.Reader) bool { | ||
| // This setting is needed so we can write integration tests for the TTY input. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4410
Also makes sure that
shellchecks the --tty flagCould probably use some tests, this is code only