editflags: support multiple --set
flags instead of ignoring all but the last such parameter
#4197
+52
−46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use lima-based development instructions (from the Kubernetes CAPI project docs):
and it turned out that the sysctl settings that are supposed to be applied in the first
--set
argument are totally ignored without warning because that's how command line parsers usually work. Users should definitely be able to specify this multiple times, so I added support for that.