Fix EP8 DP/TP RSAG init and empty LM head#416
Open
yubofredwang wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16db5f6e86
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0966624 to
eb49594
Compare
Signed-off-by: Yubo Wang <yubowang2019@gmail.com>
eb49594 to
58d3ee5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR narrows the EP8/DP2/TP4 fix to two concrete runtime issues:
Follow-up work is intentionally left out of this PR: global-to-local
gather_idslayout handling, sampler output merge semantics, output logprobs with local logits, and EAGLE3/NextN hidden-capture merging.Test Plan
.venv/bin/python -m pytest test/runtime/distributed/test_comm_ops.py::TestAutoBackendRsagPrecreate test/runtime/test_logits_processor.py -q.venv/bin/pre-commit run --all-filesAdditional manual validation from the investigation: