-
Notifications
You must be signed in to change notification settings - Fork 421
Zero fee commitment test vectors #4202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
To be used in the commits that follow for zero fee commitment test vectors.
In v3 test vectors, we're using real preimages so won't be able to use the workaround here.
|
👋 Thanks for assigning @tankyleo as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4202 +/- ##
==========================================
+ Coverage 89.28% 89.29% +0.01%
==========================================
Files 180 180
Lines 137913 137913
Branches 137913 137913
==========================================
+ Hits 123134 123154 +20
+ Misses 12163 12149 -14
+ Partials 2616 2610 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🔔 1st Reminder Hey @tankyleo! This PR has been waiting for your review. |
|
🔔 2nd Reminder Hey @tankyleo! This PR has been waiting for your review. |
|
🔔 3rd Reminder Hey @tankyleo! This PR has been waiting for your review. |
Needs some serious cleaning up, so please don't review yet!
Opening up early because I'll be out till the 10th, want to have a passing version of these up in the meantime.