test(sprite): add tests for texture reuse, mapping, and missing frames #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results: ✅ PASSEDRun at: 2025-12-02T14:13:48.626Z Summary: |
Test Results: ✅ PASSEDRun at: 2025-12-03T08:11:13.465Z Summary: |
| ? Object.assign({}, this.map.defaults || {}, this.map.frames[this.frame]) | ||
| : this.map[this.frame] | ||
| if ('frames' in this.map && this.map.frames !== null && this.map.frames !== undefined) { | ||
| if (this.frame in this.map.frames) { |
Collaborator
There was a problem hiding this comment.
is it necessary for this condition to be nested? or can it be included in the condition one level up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests covering Sprite texture creation, reuse, and SubTexture mapping.
Includes cases for missing frames, invalid inputs, and fallback behavior.