Addressed the issue with using a computed prop as the source for loop data. #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Observed that while using computed property as for-loop data collection then for-loop effect is not tracking for all the other instance variables which are using in computed property function defintion. Ideally changes to any property inside computed function should execute for-loop again, This PR will actually collect list of those component refferences inside each computed method and track for-loop for all those component variables. Signed-off-by: Suresh Kumar Gangumalla <[email protected]>
suresh-gangumalla
requested a review
from michielvandergeest
as a code owner
Test Results: ❌ FAILEDRun at: 2025-11-27T06:39:18.426Z Summary: |
suresh-gangumalla
changed the title
Signed-off-by: Suresh Kumar Gangumalla <[email protected]>
Test Results: ❌ FAILEDRun at: 2025-11-27T07:28:43.714Z Summary: |
|
Hi @suresh-gangumalla, I've already addressed this in #541, can you check and verify? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed that while using computed property as for-loop data collection then for-loop effect is not tracking for all the other instance variables which are using in computed property function defintion. Ideally changes to any property inside computed function should execute for-loop again, This PR will actually collect list of those component refferences inside each computed method and track for-loop for all those component variables.