Skip to content

Conversation

@tuncayuk
Copy link
Contributor

@tuncayuk tuncayuk commented Nov 26, 2025

  1. Change resumeInfinity to reset the existing timeout instead of calling clear() when a timer is present

  2. Introduce resumeFromKeepAlive guard so keep-alive resume() calls don’t recursively trigger resumeInfinity

Key changes for consumers:

a. You can now pass enableUtteranceKeepAlive as a configuration parameter:

this.$announcer.configure({ enableUtteranceKeepAlive: false });
this.$announcer.enable();

b. You can cancel previous utterances via an option on speak:

this.$announcer.speak(utterance, 'off', { cancelPrevious: true });

@github-actions
Copy link

Test Results: ✅ PASSED

Run at: 2025-11-26T16:01:42.800Z

Summary:
passed: 917 failed: 0 of 917 tests

Copy link
Collaborator

@michielvandergeest michielvandergeest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A few minor syntax related comments

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Test Results: ✅ PASSED

Run at: 2025-12-02T10:28:25.494Z

Summary:
passed: 917 failed: 0 of 917 tests

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Test Results: ✅ PASSED

Run at: 2025-12-03T12:17:48.082Z

Summary:
passed: 917 failed: 0 of 917 tests

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Test Results: ✅ PASSED

Run at: 2025-12-03T12:20:32.097Z

Summary:
passed: 917 failed: 0 of 917 tests

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Test Results: ✅ PASSED

Run at: 2025-12-03T14:38:24.613Z

Summary:
passed: 917 failed: 0 of 917 tests

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Test Results: ✅ PASSED

Run at: 2025-12-03T15:06:07.990Z

Summary:
passed: 917 failed: 0 of 917 tests

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Test Results: ✅ PASSED

Run at: 2025-12-04T09:07:59.870Z

Summary:
passed: 917 failed: 0 of 917 tests

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Test Results: ✅ PASSED

Run at: 2025-12-04T09:46:56.875Z

Summary:
passed: 917 failed: 0 of 917 tests

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Test Results: ✅ PASSED

Run at: 2025-12-05T10:56:39.578Z

Summary:
passed: 917 failed: 0 of 917 tests

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Test Results: ✅ PASSED

Run at: 2025-12-08T13:39:40.543Z

Summary:
passed: 917 failed: 0 of 917 tests

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Test Results: ✅ PASSED

Run at: 2025-12-08T16:10:34.947Z

Summary:
passed: 917 failed: 0 of 917 tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants