-
Notifications
You must be signed in to change notification settings - Fork 33
fix: resumeInfinity/onresume interaction #544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Test Results: ✅ PASSEDRun at: 2025-11-26T16:01:42.800Z Summary: |
michielvandergeest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! A few minor syntax related comments
Test Results: ✅ PASSEDRun at: 2025-12-02T10:28:25.494Z Summary: |
Test Results: ✅ PASSEDRun at: 2025-12-03T12:17:48.082Z Summary: |
Test Results: ✅ PASSEDRun at: 2025-12-03T12:20:32.097Z Summary: |
Test Results: ✅ PASSEDRun at: 2025-12-03T14:38:24.613Z Summary: |
Test Results: ✅ PASSEDRun at: 2025-12-03T15:06:07.990Z Summary: |
…meInfinity function
Test Results: ✅ PASSEDRun at: 2025-12-04T09:07:59.870Z Summary: |
Test Results: ✅ PASSEDRun at: 2025-12-04T09:46:56.875Z Summary: |
Test Results: ✅ PASSEDRun at: 2025-12-05T10:56:39.578Z Summary: |
Test Results: ✅ PASSEDRun at: 2025-12-08T13:39:40.543Z Summary: |
Test Results: ✅ PASSEDRun at: 2025-12-08T16:10:34.947Z Summary: |
Change resumeInfinity to reset the existing timeout instead of calling clear() when a timer is present
Introduce resumeFromKeepAlive guard so keep-alive resume() calls don’t recursively trigger resumeInfinity
Key changes for consumers:
a. You can now pass enableUtteranceKeepAlive as a configuration parameter:
b. You can cancel previous utterances via an option on speak: