screen to be on if playing game or watching game

[MunibullahShah]

#1835

[veloce]

There is already a WakeLock widget. You should use it, no need to create one.

Also game screen is already keeping screen on (contrary to what the issue says...), so no need to modify game screen.
Happens here:

mobile/lib/src/view/game/game_body.dart

Line 215 in cd0d627

child: WakelockWidget(

(admitedly it would be better if it was on game screen, it could be changed);

[MunibullahShah]

Removed the services created and used the already-made widget.
Also moved the Wakelock from GameBody to GameScreen with the condition if the loadedGame !=null

[veloce]

The problem is that it is not the condition we want.

Before it was:

shouldEnableOnFocusGained: () => gameState.game.playable,

So I think you should revert the changes on game_body.dart and game_screen.dart.

[veloce]

Code formatting is wrong for game_screen.dart; you can fix it by running dart format lib/src

[veloce]

This code does nothing, it can be removed.

[veloce]

Sorry if the comment was not placed on the good line.

This is useful:

final _whiteClockKey = GlobalKey(debugLabel: 'whiteClockOnTvScreen');
  final _blackClockKey = GlobalKey(debugLabel: 'blackClockOnTvScreen');

This is useless:

@override
  void initState() {
    super.initState();
  }

  @override
  void dispose() {
    super.dispose();
  }

[veloce]

please remove that

[MunibullahShah]

They are being used in GameBody where the comments says that these variables are being used to preserve state if orientation changes.

[veloce]

I meant the empty initState and dispose; they are useless here.

[MunibullahShah]

Got it, removing it now :)

[MunibullahShah]

@veloce any update on this?

[MunibullahShah]

@veloce removed the code in both files

[veloce]

Sorry for the delay.
I still cannot accept the PR because these keys are removed where they should be kept.

[veloce]

Closing due to inactivity.