Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Implements the move-friendly accessor improvements requested in issue #95. Adds ref-qualified and rvalue overloads so temporaries can return buffers by move, eliminating unnecessary copies while keeping lvalue behavior unchanged.
Problem
toBuffer/toVectorreturned const references only, forcing an extra copy when called on temporaries.Multihashstored data in a const shared_ptr, blocking safe move-out even when uniquely owned.Solution
toBufferandtoVectoronMultihash,UVarint, andPeerId.Multihashto move out its byte buffer when uniquely owned; fall back to const& otherwise.Key Changes
include/libp2p/multi/multihash.hpp/src/multi/multihash.cpp: ref-qualified accessors; move-out path whenDatais uniquely owned.include/libp2p/multi/uvarint.hpp/src/multi/uvarint.cpp: add rvaluetoVectorto move backing bytes from temporaries.include/libp2p/peer/peer_id.hpp/src/peer/peer_id.cpp: rvaluetoVectordelegates to movedMultihash.Closes #95