Skip to content

Conversation

@zond
Copy link
Contributor

@zond zond commented Jul 8, 2024

Also made the Debian build rule use it.

Description

Pull Request Checklist

  • CLA Signed: Have you signed the Contributor License Agreement (individual or corporate, as appropriate)? Only contributions from signed contributors can be accepted.
  • Authors: Have you considered adding your name to the AUTHORS file?
  • Code Style: Have you ensured your code adheres to the project's coding style guidelines? You can use ./ci.sh lint for automatic code formatting.

Please review the full contributing guidelines for more details.

Also made the Debian build rule use it.
@zond
Copy link
Contributor Author

zond commented Jul 8, 2024

@szabadka, @malaterre PTAL at this.

I just added the same workaround for JPEG in the jpegli cmake setup as we already use for e.g. brotli in the jxl cmake setup.

./ci.sh opt now produces build/lib/jpegli/libjpeg.so even with an empty third_party/libjpeg-turbo.

I also made the debian/rules file pick that up.

What I haven't done and don't know how to do: Make the debian build actually depend on libjpeg62-turbo and libjpeg62-turbo-dev.

What else needs to be done?

@malaterre
Copy link
Contributor

What I haven't done and don't know how to do: Make the debian build actually depend on libjpeg62-turbo and libjpeg62-turbo-dev.

I'll do that within debian package only. Thanks

@mo271 mo271 added unrelated to 1.0 Things that need not be done before the 1.0 version milestone jpegli Related to jpegli, also cjpegli and djpegli labels Aug 5, 2024
@Traneptora
Copy link
Contributor

libjxl should link to system libjpeg even if jpegli build is enabled. You can test it yourself by encoding a jpeg to a lossless jxl with cjxl, and comparing the result with what happens if you run /usr/bin/djpeg versus djpegli.

@zond zond closed this Sep 17, 2024
@malaterre
Copy link
Contributor

@zond could you please be a little more verbose ? what is going on with this patch ? thanks

@zond
Copy link
Contributor Author

zond commented Sep 17, 2024

Sorry, should have explained more.

Since jpegli is moving to https://github.com/google/jpegli/, it's no longer relevant to fix the jpegli build in this repository.

The new PR to fix jpegli build in Debian is google/jpegli#31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jpegli Related to jpegli, also cjpegli and djpegli unrelated to 1.0 Things that need not be done before the 1.0 version milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants