Modernize: replace macros with inline functions#18
Open
GravisZro wants to merge 2 commits intolibigl:masterfrom
Open
Modernize: replace macros with inline functions#18GravisZro wants to merge 2 commits intolibigl:masterfrom
GravisZro wants to merge 2 commits intolibigl:masterfrom
Conversation
Prepare macros to be converted into functions by including all the required parameters for when converted.
Macros lose type information. Replace macros with inline functions.
|
Your PRs cannot merged without merge conflicts. Perhaps a summary PR would be a sensible idea? |
Author
|
@robinchrist Generally people want fine grained PRs (to investigate changes) and then rebase each PR as needed to resolve conflicts. Anyway, if you want one large PR then I can make it that way. |
Author
|
@robinchrist Do you want me to combine these PRs into a single PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mesh*type varaible (akam) needs to be passed in for several)