Add cross-field-related python bindings#295
Merged
alecjacobson merged 7 commits intolibigl:mainfrom Jan 27, 2026
Merged
Conversation
Contributor
|
Thanks. Do you mind adding tests? Just calling the function with valid input is enough. |
Contributor
|
I'm not sure why the CI isn't launching... |
Contributor
Author
It seems the result of |
Contributor
Author
|
I updated the unit test to avoid using principal curvatures (which is a per-vertex quantity). However, the unit test is still failing the Poincaré-Hopf test. Not sure why. Maybe I am interpreting SingularityIndex wrong? |
Contributor
|
Oh cool. You put real tests. So far the python tests have been mostly of the style does this function not crash when called with valid input. (and relying on C++ libigl unit tests to do more real testing of functional correctness). |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
comb_cross_fieldcomb_frame_fieldcompute_frame_field_bisectorscross_field_mismatchfind_cross_field_singularitiesrotate_vectors