fix: align sidebar footer actions - #1288
Open
Sure-Will wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Align the Theme, Language, and Sign Out actions in the expanded sidebar footer.
The Theme toggle wrapped its icons in a container, so the shared button selector for direct SVG children did not apply the same horizontal padding used by the other actions. The Sign Out action also used a larger gap. This change gives the Theme toggle an explicit 12 px horizontal inset, uses a 16 px icon container, and applies the same 8 px gap to all three actions.
Related Issue
N/A (small, obvious UI fix)
Type of Change
How Has This Been Tested?
Test Details:
npm run test: 23 test files and 141 tests passed.npm run lint: completed with no errors. The seven existing warnings are outside the changed files.npm run build: production build and TypeScript checks passed.Design Alignment
Which design principles does this PR support?
Explanation:
This is a focused consistency fix for existing controls. It adds no new behavior or configuration.
Checklist
Code Quality
Testing
npm run lintnpm run buildDocumentation
/docs(not applicable)Database Changes
Breaking Changes
Screenshots
Before
The Theme icon is shifted 4 px to the right of the Language and Sign Out icons.
After
The three icons now share the same horizontal position and spacing.
Additional Context
This is a three-file frontend-only change with no dependency, API, database, or documentation impact.
Pre-Submission Verification
CONTRIBUTING.mdVISION.md